Skip to content

[build]: add tests for dockerfile arg parsing#1342

Merged
jglogan merged 2 commits into
apple:mainfrom
saehejkang:add-test-cases-for-build
Mar 30, 2026
Merged

[build]: add tests for dockerfile arg parsing#1342
jglogan merged 2 commits into
apple:mainfrom
saehejkang:add-test-cases-for-build

Conversation

@saehejkang

@saehejkang saehejkang commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Relates to #1295

Test cases added for validation based on changes from apple/container-builder-shim#70.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@saehejkang saehejkang changed the title [build]: add tests for arg normalization [build]: add tests for arg parsing and normalization Mar 25, 2026
@saehejkang saehejkang force-pushed the add-test-cases-for-build branch from 886e061 to b0401c5 Compare March 25, 2026 03:23
@saehejkang saehejkang changed the title [build]: add tests for arg parsing and normalization [build]: add tests for dockerfile arg parsing Mar 28, 2026
@jglogan jglogan requested a review from JaewonHur March 29, 2026 19:52
@jglogan

jglogan commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

@JaewonHur added you as reviewer after you sign off and merge apple/container-builder-shim#70, and tag the updated builder.

@saehejkang Once there's a new container-builder-shim tag, could you update this PR to reference the latest builder release in Package.swift?

@saehejkang

Copy link
Copy Markdown
Contributor Author

Note: CI is expected to fail until apple/container-builder-shim#70 is merged and the new release of the shim is referenced

@saehejkang

Copy link
Copy Markdown
Contributor Author

Once there's a new container-builder-shim tag, could you update this PR to reference the latest builder release in Package.swift?

yes, I will make those changes here

@JaewonHur

Copy link
Copy Markdown
Contributor

Hi @saehejkang !
I updated tag 0.11.0 in container-buider-shim. Could you update this PR to point that tag and test again?

@jglogan

jglogan commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

@saehejkang If you can get the version update in such that the build works in the next couple hours, we can include this in 0.11.0.

@jglogan jglogan mentioned this pull request Mar 30, 2026
7 tasks
jglogan added a commit that referenced this pull request Mar 30, 2026
- Part of #1295.
- Needed for #1342.
- If APP_ROOT is defined, remove everything but kernel from data
directory before starting integration test.
- Adds `--enable-kernel-install` for system start on integration test.
@jglogan

jglogan commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

@saehejkang If you can get the version update in such that the build works in the next couple hours, we can include this in 0.11.0.

I did a 0.11.0 update and patched your test changes in, worked fine!

Merged the update and then merged that into the PR, testing now. 🤞

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saehejkang Thank you for adding these tests! Merged.

@jglogan jglogan merged commit c501c87 into apple:main Mar 30, 2026
3 checks passed
@saehejkang saehejkang deleted the add-test-cases-for-build branch March 31, 2026 04:06
@saehejkang

Copy link
Copy Markdown
Contributor Author

If you can get the version update in such that the build works in the next couple hours, we can include this in 0.11.0.

@jglogan Apologies for not being able to make these changes when you asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants