[build]: add tests for dockerfile arg parsing#1342
Conversation
886e061 to
b0401c5
Compare
|
@JaewonHur added you as reviewer after you sign off and merge apple/container-builder-shim#70, and tag the updated builder. @saehejkang Once there's a new container-builder-shim tag, could you update this PR to reference the latest builder release in Package.swift? |
|
Note: CI is expected to fail until apple/container-builder-shim#70 is merged and the new release of the shim is referenced |
yes, I will make those changes here |
|
Hi @saehejkang ! |
|
@saehejkang If you can get the version update in such that the build works in the next couple hours, we can include this in 0.11.0. |
I did a 0.11.0 update and patched your test changes in, worked fine! Merged the update and then merged that into the PR, testing now. 🤞 |
jglogan
left a comment
There was a problem hiding this comment.
@saehejkang Thank you for adding these tests! Merged.
@jglogan Apologies for not being able to make these changes when you asked. |
Type of Change
Motivation and Context
Relates to #1295
Test cases added for validation based on changes from apple/container-builder-shim#70.
Testing