Fix incorrect creationDate for networks.#926
Merged
Merged
Conversation
- When the API service enumerates creation dates, the configuration value from the network helper is used instead of the persistent config value, so the creation date winds up being the current time. The short term fix is for the API server to return NetworkState values that combine the API server's persistent network config with the network status returned from the helper. - The longer term refinement could be to define a uniform model for resources where each resource type has Metadata (id/Identifiable, creationDate, labels), and type-specific configuration and state/status.
realrajaryan
approved these changes
Dec 2, 2025
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
- Fixes apple#925. - When the API service enumerates creation dates, the configuration value from the network helper is used instead of the persistent config value, so the creation date winds up being the current time. The short term fix is for the API server to return NetworkState values that combine the API server's persistent network config with the network status returned from the helper. - The longer term refinement could be to define a uniform model for resources where each resource type has Metadata (id/Identifiable, creationDate, labels), and type-specific configuration and state/status. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context See above. ## Testing - [x] Tested locally - [ ] Added/updated tests - [ ] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creationDateincorrect. #925.Type of Change
Motivation and Context
See above.
Testing