Skip to content

Added button space view that fill safe area bottom space till input view#447

Merged
azimin merged 4 commits intomasterfrom
bugfix/bottom-space-view-for-safe-area
Feb 16, 2018
Merged

Added button space view that fill safe area bottom space till input view#447
azimin merged 4 commits intomasterfrom
bugfix/bottom-space-view-for-safe-area

Conversation

@azimin
Copy link
Copy Markdown
Contributor

@azimin azimin commented Feb 16, 2018

This should fix #398

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 16, 2018

Codecov Report

Merging #447 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   64.47%   64.65%   +0.17%     
==========================================
  Files          74       74              
  Lines        3851     3862      +11     
==========================================
+ Hits         2483     2497      +14     
+ Misses       1368     1365       -3
Impacted Files Coverage Δ
...Source/ChatController/BaseChatViewController.swift 83.58% <100%> (+0.95%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 75.41% <0%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebd21f...23c0ab3. Read the comment docs.

@AntonPalich AntonPalich self-requested a review February 16, 2018 14:29
@azimin azimin merged commit 8eb2083 into master Feb 16, 2018
@AntonPalich AntonPalich deleted the bugfix/bottom-space-view-for-safe-area branch March 10, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Messages appear inside safe area in iPhone X

3 participants