Skip to content

Fixed an issue with a wrong input view height after sending a multiline text message #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntonPalich merged 3 commits into from
Apr 5, 2019
Merged

Fixed an issue with a wrong input view height after sending a multiline text message #568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a1efaf
Fixed an issue with a wrong input view height after sending a multili…
Apr 3, 2019
e3c38ec
Merge branch 'master' into fix_wrong_input_view_height_after_sending_…
AntonPalich Apr 5, 2019
a0afaa9
Applied a code review suggestion
Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Chatto/Source/ChatController/Collaborators/KeyboardTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,14 @@ class KeyboardTracker {
if self.keyboardTrackerView.preferredSize.height != inputContainerHeight {
self.keyboardTrackerView.preferredSize.height = inputContainerHeight
self.isPerformingForcedLayout = true

// Sometimes, the autolayout system doesn't finish the layout inside of the input bar container at this point.
// If it happens, then the input bar may have a height different than an input bar container.
// We need to ensure that their heights are the same; otherwise, it would lead to incorrect calculations that in turn affects lastKnownKeyboardHeight.
// Tracking view adjustment changes a keyboard height and triggers an update of lastKnownKeyboardHeight.
self.inputBarContainer.layoutIfNeeded()
self.keyboardTrackerView.window?.layoutIfNeeded()

self.isPerformingForcedLayout = false
}
}
Expand Down