Skip to content

Use CATransaction to set completion block in changeInputContentBottomMarginTo#599

Merged
leonspok merged 1 commit intomasterfrom
change-input-content-bottom-margin-to-callback-fix
Aug 6, 2019
Merged

Use CATransaction to set completion block in changeInputContentBottomMarginTo#599
leonspok merged 1 commit intomasterfrom
change-input-content-bottom-margin-to-callback-fix

Conversation

@leonspok
Copy link
Copy Markdown
Contributor

@leonspok leonspok commented Aug 1, 2019

I found that completion block from UIView.animate is not called if animation is started after interactive pop gesture begins. Using CATransaction's completion block fixes the issue.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 1, 2019

Codecov Report

Merging #599 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
- Coverage   57.97%   57.91%   -0.06%     
==========================================
  Files          91       91              
  Lines        3879     3883       +4     
==========================================
  Hits         2249     2249              
- Misses       1630     1634       +4
Impacted Files Coverage Δ
...Source/ChatController/BaseChatViewController.swift 67.98% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328fd1c...61087e9. Read the comment docs.

@leonspok leonspok requested a review from MikhailGasanov August 5, 2019 10:06
@leonspok leonspok merged commit f1da3a3 into master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants