Adding allow timestamp revealing boolean#704
Merged
simoneBumble merged 2 commits intomasterfrom May 4, 2021
Merged
Conversation
wiruzx
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is required in order to allow a different timestamp revealing behaviour (managed by the CellPanGestureHandler) of the apps that share the same implementation of this framework. This PR simply adds a new boolean called allowTimestampRevealing (defaulted to true in order to ensure backward compatibility) which the CellPanGestureHandler guards against when a right to left pan is detected (translation.x < 0).