fix(analyzer): noUselessEscapeInRegex preserves required v-flag escapes by jiwon79 · Pull Request #10084 · biomejs/biome

jiwon79 · 2026-04-22T10:20:20Z

Summary

Fix #10034
noUselessEscapeInRegex was treating the 13 ClassSetReservedPunctuator characters (&, !, #, %, ,, :, ;, <, =, >, @, `, ~) the same as the 5 doubled-only punctuators ($, *, +, ., ?) when evaluating escapes inside a v-flag character class. Per ECMA-262, the first group is reserved as individual code points in v-mode, so the escape is required even for a single occurrence — not only when doubled.

As a result, patterns like /[a-z\&]/v were flagged as having a useless escape, and the safe auto-fix stripped the backslash, producing a regex that is invalid per the strict spec.

Test Plan

Added valid.js cases for each of the 13 reserved punctuators, both as single (/[\&]/v) and doubled (/[\&\&]/v) escapes.
Removed the corresponding cases from invalid.js that assumed the old buggy behavior.
Existing tests for the 5 doubled-only punctuators are unchanged.

Docs

Rustdoc updated inline.

+) Developed with Claude Code assistance. Direction and review were mine; code and test drafts were AI-assisted.

changeset-bot · 2026-04-22T10:20:25Z

🦋 Changeset detected

Latest commit: 65225f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-22T10:25:31Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Refines the noUselessEscapeInRegex lint: escapes inside v‑flag character classes are reclassified into two TC39‑aligned sets. Escapes for ClassSetReservedPunctuator (& ! # % , : ; < = > @ \ ~) are treated as necessary (no diagnostic). Escapes for ClassSetReservedDoublePunctuator ($ * + . ?) are reported as useless unless part of a doubled punctuator pair. Tests were updated accordingly (removed invalid cases for the first set; added valid v‑mode fixtures) and a changeset for @biomejs/biome` was added.

Suggested labels

A-Diagnostic

Suggested reviewers

ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarises the main fix: preserving required v-flag escapes in the noUselessEscapeInRegex rule.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description clearly relates to the changeset, explaining the bug fix for noUselessEscapeInRegex rule handling of v-flag character classes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js (1)
103-134: Nice thorough fixture expansion. One tiny gap for symmetry.

The doubled-escape block (lines 122–133) covers 12 of the 13 reserved punctuators but is missing /[\%\%]/v;. The single case on line 111 already exercises the same code path, so this is purely cosmetic completeness.
🧹 Optional symmetry tweak
 /[\#\#]/v;
+/[\%\%]/v;
 /[\,\,]/v;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js`
around lines 103 - 134, The doubled-escape block for reserved punctuators is
missing the percent pair; add the symmetric doubled-escape `/[\%\%]/v;` into the
same doubled-escape section (the block containing `/[\&\&]/v;`, `/[\!\!]/v;`,
etc.) so that all 13 ClassSetReservedPunctuator characters are covered (there is
already a single-escape `/[\%]/v;` earlier).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js`:
- Around line 103-134: The doubled-escape block for reserved punctuators is
missing the percent pair; add the symmetric doubled-escape `/[\%\%]/v;` into the
same doubled-escape section (the block containing `/[\&\&]/v;`, `/[\!\!]/v;`,
etc.) so that all 13 ClassSetReservedPunctuator characters are covered (there is
already a single-escape `/[\%]/v;` earlier).

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4eb55a8-f50f-4be9-90f1-339a5341a550

📥 Commits

Reviewing files that changed from the base of the PR and between bc05a24 and dcbffa8.

⛔ Files ignored due to path filters (2)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (4)

.changeset/bumpy-moose-allow.md
crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js

💤 Files with no reviewable changes (1)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js

…peInRegex valid fixture Completes symmetry for the 13 `ClassSetReservedPunctuator` characters in the doubled-escape block. Spotted by CodeRabbit review on biomejs#10084. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jiwon79 · 2026-04-22T10:35:49Z

🧹 Nitpick comments (1)
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js (1)
103-134: Nice thorough fixture expansion. One tiny gap for symmetry.

The doubled-escape block (lines 122–133) covers 12 of the 13 reserved punctuators but is missing /[\%\%]/v;. The single case on line 111 already exercises the same code path, so this is purely cosmetic completeness.
🧹 Optional symmetry tweak
 /[\#\#]/v;
+/[\%\%]/v;
 /[\,\,]/v;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js`
around lines 103 - 134, The doubled-escape block for reserved punctuators is
missing the percent pair; add the symmetric doubled-escape `/[\%\%]/v;` into the
same doubled-escape section (the block containing `/[\&\&]/v;`, `/[\!\!]/v;`,
etc.) so that all 13 ClassSetReservedPunctuator characters are covered (there is
already a single-escape `/[\%]/v;` earlier).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js`:
- Around line 103-134: The doubled-escape block for reserved punctuators is
missing the percent pair; add the symmetric doubled-escape `/[\%\%]/v;` into the
same doubled-escape section (the block containing `/[\&\&]/v;`, `/[\!\!]/v;`,
etc.) so that all 13 ClassSetReservedPunctuator characters are covered (there is
already a single-escape `/[\%]/v;` earlier).
ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4eb55a8-f50f-4be9-90f1-339a5341a550

📥 Commits

Reviewing files that changed from the base of the PR and between bc05a24 and dcbffa8.

⛔ Files ignored due to path filters (2)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js.snap is excluded by !**/*.snap and included by **

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (4)

.changeset/bumpy-moose-allow.md

crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js

💤 Files with no reviewable changes (1)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js

Apply it at 77bfd17

…elessEscapeInRegex Address review feedback on biomejs#10084 by pointing readers to the relevant ECMA-262 productions so the comment terms are traceable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

codspeed-hq · 2026-04-22T11:27:24Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks¹

_{Comparing jiwon79:fix/no-useless-escape-regex-v-flag (65225f5) with main (98cc11e)²}

196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (38deeae) during the generation of this report, so 98cc11e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

…peInRegex valid fixture Completes symmetry for the 13 `ClassSetReservedPunctuator` characters in the doubled-escape block. Spotted by CodeRabbit review on biomejs#10084. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…elessEscapeInRegex Address review feedback on biomejs#10084 by pointing readers to the relevant ECMA-262 productions so the comment terms are traceable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs`:
- Around line 39-42: The rule implementation in no_useless_escape_in_regex.rs
incorrectly treats any escaped single punctuator in `/v` regexes as safe; update
the logic so that instead of exempting all single punctuator escapes you only
treat an escape as necessary when removing the backslash would form a reserved
doubled punctuator pair (i.e., consolidate the check currently in the
single-punctuator branch into the doubled-punctuator logic and only flag escapes
when dropping the backslash creates a reserved pair like `&&` or `!!`), update
the corresponding validation code path in the function that detects useless
escapes (the regex escape inspection in this module), remove the `/[\&]/v`
example from the doc comment examples, and then run `just gen-rules` and `just
gen-configuration` before opening the PR.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bef99990-8ff3-44c2-92a1-997889da7500

📥 Commits

Reviewing files that changed from the base of the PR and between 3b81f0e and b5eb25f.

⛔ Files ignored due to path filters (2)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (4)

.changeset/bumpy-moose-allow.md
crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js
crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js

💤 Files with no reviewable changes (1)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/invalid.js

✅ Files skipped from review due to trivial changes (1)

.changeset/bumpy-moose-allow.md

🚧 Files skipped from review as they are similar to previous changes (1)

crates/biome_js_analyze/tests/specs/complexity/noUselessEscapeInRegex/valid.js

…peInRegex valid fixture Completes symmetry for the 13 `ClassSetReservedPunctuator` characters in the doubled-escape block. Spotted by CodeRabbit review on biomejs#10084. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…elessEscapeInRegex Address review feedback on biomejs#10084 by pointing readers to the relevant ECMA-262 productions so the comment terms are traceable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…erved punctuators Add valid.js cases covering `ClassSetReservedPunctuator` characters (& ! # % , : ; < = > @ ` ~) in v-mode character classes, both as single and doubled escapes. Per ECMA-262, these characters are reserved as individual code points in v-mode and require escaping. Remove invalid.js cases that assumed the current buggy behavior (flagging these escapes as useless). Source code fix follows. Refs biomejs#10034. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Split the doubled-punctuator match arm into two groups: - `ClassSetReservedPunctuator` (& ! # % , : ; < = > @ ` ~): reserved as individual characters in v-mode character classes per ECMA-262, so any escape on these characters is required, not useless. - Characters that only form a `ClassSetReservedDoublePunctuator` when doubled ($ * + . ?): retain the existing "useless unless doubled" behavior. Previously, `/[a-z\&]/v` and similar patterns were flagged as having a useless escape, and the auto-fix stripped the backslash, producing a regex that is invalid per the strict spec. Also move the `/[\&]/v` rustdoc example from Invalid to Valid to match the new behavior. Fixes biomejs#10034. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…peInRegex valid fixture Completes symmetry for the 13 `ClassSetReservedPunctuator` characters in the doubled-escape block. Spotted by CodeRabbit review on biomejs#10084. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…elessEscapeInRegex Address review feedback on biomejs#10084 by pointing readers to the relevant ECMA-262 productions so the comment terms are traceable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | patch | `2.4.12` → `2.4.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.13`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2413) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.12...@biomejs/biome@2.4.13) ##### Patch Changes - [#9969](biomejs/biome#9969) [`c5eb92b`](biomejs/biome@c5eb92b) Thanks [@officialasishkumar](https://github.com/officialasishkumar)! - Added the nursery rule [`noUnnecessaryTemplateExpression`](https://biomejs.dev/linter/rules/no-unnecessary-template-expression/), which disallows template literals that only contain string literal expressions. These can be replaced with a simpler string literal. For example, the following code triggers the rule: ```js const a = `${"hello"}`; // can be 'hello' const b = `${"prefix"}_suffix`; // can be 'prefix_suffix' const c = `${"a"}${"b"}`; // can be 'ab' ``` - [#10037](biomejs/biome#10037) [`f785e8c`](biomejs/biome@f785e8c) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) no longer reports false positives on a getter with a matching setter in the same namespace. ```ts class Store { get status(): string { if (Math.random() > 0.5) return "loading"; return "idle"; } set status(v: string) {} } ``` - [#10084](biomejs/biome#10084) [`5e2f90c`](biomejs/biome@5e2f90c) Thanks [@jiwon79](https://github.com/jiwon79)! - Fixed [#10034](biomejs/biome#10034): [`noUselessEscapeInRegex`](https://biomejs.dev/linter/rules/no-useless-escape-in-regex/) no longer flags escapes of `ClassSetReservedPunctuator` characters (`&`, `!`, `#`, `%`, `,`, `:`, `;`, `<`, `=`, `>`, `@`, `` ` ``, `~`) inside `v`-flag character classes as useless. These characters are reserved as individual code points in `v`-mode, so the escape is required. The following pattern is now considered valid: ```js /[a-z\&]/v; ``` - [#10063](biomejs/biome#10063) [`c9ffa16`](biomejs/biome@c9ffa16) Thanks [@Netail](https://github.com/Netail)! - Added extra rule sources from ESLint CSS. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations. - [#10035](biomejs/biome#10035) [`946b50e`](biomejs/biome@946b50e) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10032](biomejs/biome#10032): [useIframeSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox/) now flags if there's no initializer value. - [#9865](biomejs/biome#9865) [`68fb8d4`](biomejs/biome@68fb8d4) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useDomNodeTextContent`](https://biomejs.dev/linter/rules/use-dom-node-text-content/), which prefers `textContent` over `innerText` for DOM node text access and destructuring. For example, the following snippet triggers the rule: ```js const foo = node.innerText; ``` - [#10023](biomejs/biome#10023) [`bd1e74f`](biomejs/biome@bd1e74f) Thanks [@ematipico](https://github.com/ematipico)! - Added a new nursery rule [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) that disallows deep imports from the `react-native` package. Internal paths like `react-native/Libraries/...` are not part of the public API and may change between versions. For example, the following code triggers the rule: ```js import View from "react-native/Libraries/Components/View/View"; ``` - [#9885](biomejs/biome#9885) [`3dce737`](biomejs/biome@3dce737) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useDomQuerySelector`](https://biomejs.dev/linter/rules/use-dom-query-selector/) that prefers `querySelector()` and `querySelectorAll()` over older DOM query methods such as `getElementById()` and `getElementsByClassName()`. - [#9995](biomejs/biome#9995) [`4da9caf`](biomejs/biome@4da9caf) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [#9994](biomejs/biome#9994): Biome now parses nested CSS rules correctly when declarations follow them inside embedded snippets. - [#10009](biomejs/biome#10009) [`b41cc5a`](biomejs/biome@b41cc5a) Thanks [@Jayllyz](https://github.com/Jayllyz)! - Fixed [#10004](biomejs/biome#10004): [`noComponentHookFactories`](https://biomejs.dev/linter/rules/no-component-hook-factories/) no longer reports false positives for object methods and class methods. - [#9988](biomejs/biome#9988) [`eabf54a`](biomejs/biome@eabf54a) Thanks [@Netail](https://github.com/Netail)! - Tweaked the diagnostics range for [useAltText](https://biomejs.dev/linter/rules/use-alt-text), [useButtonType](https://biomejs.dev/linter/rules/use-button-type), [useHtmlLang](https://biomejs.dev/linter/rules/use-html-lang), [useIframeTitle](https://biomejs.dev/linter/rules/use-iframe-title), [useValidAriaRole](https://biomejs.dev/linter/rules/use-valid-aria-role) & [useIfameSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox) to report on the opening tag instead of the full tag. - [#10043](biomejs/biome#10043) [`fc65902`](biomejs/biome@fc65902) Thanks [@mujpao](https://github.com/mujpao)! - Fixed [#10003](biomejs/biome#10003): Biome no longer panics when parsing Svelte files containing `{#}`. - [#9815](biomejs/biome#9815) [`5cc83b1`](biomejs/biome@5cc83b1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`noLoopFunc`](https://biomejs.dev/linter/rules/no-loop-func/). When enabled, it warns when a function declared inside a loop captures outer variables that can change across iterations. - [#9702](biomejs/biome#9702) [`ef470ba`](biomejs/biome@ef470ba) Thanks [@ryan-m-walker](https://github.com/ryan-m-walker)! - Added the nursery rule [`useRegexpTest`](https://biomejs.dev/linter/rules/use-regexp-test/) that enforces `RegExp.prototype.test()` over `String.prototype.match()` and `RegExp.prototype.exec()` in boolean contexts. `test()` returns a boolean directly, avoiding unnecessary computation of match results. **Invalid** ```js if ("hello world".match(/hello/)) { } ``` **Valid** ```js if (/hello/.test("hello world")) { } ``` - [#9743](biomejs/biome#9743) [`245307d`](biomejs/biome@245307d) Thanks [@leetdavid](https://github.com/leetdavid)! - Fixed [#2245](biomejs/biome#2245): Svelte `<script>` tag language detection when the `generics` attribute contains `>` characters (e.g., `<script lang="ts" generics="T extends Record<string, unknown>">`). Biome now correctly recognizes TypeScript in such script blocks. - [#10046](biomejs/biome#10046) [`0707de7`](biomejs/biome@0707de7) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10038](biomejs/biome#10038): [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) now sorts imports in TypeScript modules and declaration files. ```diff declare module "mymodule" { - import type { B } from "b"; import type { A } from "a"; + import type { B } from "b"; } ``` - [#10012](biomejs/biome#10012) [`94ccca9`](biomejs/biome@94ccca9) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeLiteralColors`](https://biomejs.dev/linter/rules/no-react-native-literal-colors/), which disallows color literals inside React Native styles. The rule belongs to the `reactNative` domain. It reports properties whose name contains `color` and whose value is a string literal when they appear inside a `StyleSheet.create(...)` call or inside a JSX attribute whose name contains `style`. ```jsx // Invalid const Hello = () => <Text style={{ backgroundColor: "#FFFFFF" }}>hi</Text>; const styles = StyleSheet.create({ text: { color: "red" }, }); ``` ```jsx // Valid const red = "#f00"; const styles = StyleSheet.create({ text: { color: red }, }); ``` - [#10005](biomejs/biome#10005) [`131019e`](biomejs/biome@131019e) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeRawText`](https://biomejs.dev/linter/rules/no-react-native-raw-text/), which disallows raw text outside of `<Text>` components in React Native. The rule belongs to the new `reactNative` domain. ```jsx // Invalid <View>some text</View> <View>{'some text'}</View> ``` ```jsx // Valid <View> <Text>some text</Text> </View> ``` Additional components can be allowlisted through the `skip` option: ```json { "options": { "skip": ["Title"] } } ``` - [#9911](biomejs/biome#9911) [`1603f78`](biomejs/biome@1603f78) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noJsxLeakedDollar`](https://biomejs.dev/linter/rules/no-jsx-leaked-dollar), which flags text nodes with a trailing `$` if the next sibling node is a JSX expression. This could be an unintentional mistake, resulting in a '$' being rendered as text in the output. **Invalid**: ```jsx function MyComponent({ user }) { return <div>Hello ${user.name}</div>; } ``` - [#9999](biomejs/biome#9999) [`f42405f`](biomejs/biome@f42405f) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed `noMisleadingReturnType` incorrectly flagging functions with reassigned `let` variables. - [#10075](biomejs/biome#10075) [`295f97f`](biomejs/biome@295f97f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#9983`](biomejs/biome#9983): Biome now parses functions declared inside Svelte `#snippet` blocks without throwing errors. - [#10006](biomejs/biome#10006) [`cf4c1c9`](biomejs/biome@cf4c1c9) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): `noMisleadingReturnType` incorrectly flagging nested object literals with widened properties. - [#10033](biomejs/biome#10033) [`11ddc05`](biomejs/biome@11ddc05) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`useReactNativePlatformComponents`](https://biomejs.dev/linter/rules/use-react-native-platform-components/) that ensures platform-specific React Native components (e.g. `ProgressBarAndroid`, `ActivityIndicatorIOS`) are only imported in files with a matching platform suffix. It also reports when Android and iOS components are mixed in the same file. The following code triggers the rule when the file does not have an `.android.js` suffix: ```js // file.js import { ProgressBarAndroid } from "react-native"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/1

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | patch | `2.4.12` → `2.4.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.13`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2413) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.12...@biomejs/biome@2.4.13) ##### Patch Changes - [#9969](biomejs/biome#9969) [`c5eb92b`](biomejs/biome@c5eb92b) Thanks [@officialasishkumar](https://github.com/officialasishkumar)! - Added the nursery rule [`noUnnecessaryTemplateExpression`](https://biomejs.dev/linter/rules/no-unnecessary-template-expression/), which disallows template literals that only contain string literal expressions. These can be replaced with a simpler string literal. For example, the following code triggers the rule: ```js const a = `${"hello"}`; // can be 'hello' const b = `${"prefix"}_suffix`; // can be 'prefix_suffix' const c = `${"a"}${"b"}`; // can be 'ab' ``` - [#10037](biomejs/biome#10037) [`f785e8c`](biomejs/biome@f785e8c) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) no longer reports false positives on a getter with a matching setter in the same namespace. ```ts class Store { get status(): string { if (Math.random() > 0.5) return "loading"; return "idle"; } set status(v: string) {} } ``` - [#10084](biomejs/biome#10084) [`5e2f90c`](biomejs/biome@5e2f90c) Thanks [@jiwon79](https://github.com/jiwon79)! - Fixed [#10034](biomejs/biome#10034): [`noUselessEscapeInRegex`](https://biomejs.dev/linter/rules/no-useless-escape-in-regex/) no longer flags escapes of `ClassSetReservedPunctuator` characters (`&`, `!`, `#`, `%`, `,`, `:`, `;`, `<`, `=`, `>`, `@`, `` ` ``, `~`) inside `v`-flag character classes as useless. These characters are reserved as individual code points in `v`-mode, so the escape is required. The following pattern is now considered valid: ```js /[a-z\&]/v; ``` - [#10063](biomejs/biome#10063) [`c9ffa16`](biomejs/biome@c9ffa16) Thanks [@Netail](https://github.com/Netail)! - Added extra rule sources from ESLint CSS. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations. - [#10035](biomejs/biome#10035) [`946b50e`](biomejs/biome@946b50e) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10032](biomejs/biome#10032): [useIframeSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox/) now flags if there's no initializer value. - [#9865](biomejs/biome#9865) [`68fb8d4`](biomejs/biome@68fb8d4) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useDomNodeTextContent`](https://biomejs.dev/linter/rules/use-dom-node-text-content/), which prefers `textContent` over `innerText` for DOM node text access and destructuring. For example, the following snippet triggers the rule: ```js const foo = node.innerText; ``` - [#10023](biomejs/biome#10023) [`bd1e74f`](biomejs/biome@bd1e74f) Thanks [@ematipico](https://github.com/ematipico)! - Added a new nursery rule [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) that disallows deep imports from the `react-native` package. Internal paths like `react-native/Libraries/...` are not part of the public API and may change between versions. For example, the following code triggers the rule: ```js import View from "react-native/Libraries/Components/View/View"; ``` - [#9885](biomejs/biome#9885) [`3dce737`](biomejs/biome@3dce737) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useDomQuerySelector`](https://biomejs.dev/linter/rules/use-dom-query-selector/) that prefers `querySelector()` and `querySelectorAll()` over older DOM query methods such as `getElementById()` and `getElementsByClassName()`. - [#9995](biomejs/biome#9995) [`4da9caf`](biomejs/biome@4da9caf) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [#9994](biomejs/biome#9994): Biome now parses nested CSS rules correctly when declarations follow them inside embedded snippets. - [#10009](biomejs/biome#10009) [`b41cc5a`](biomejs/biome@b41cc5a) Thanks [@Jayllyz](https://github.com/Jayllyz)! - Fixed [#10004](biomejs/biome#10004): [`noComponentHookFactories`](https://biomejs.dev/linter/rules/no-component-hook-factories/) no longer reports false positives for object methods and class methods. - [#9988](biomejs/biome#9988) [`eabf54a`](biomejs/biome@eabf54a) Thanks [@Netail](https://github.com/Netail)! - Tweaked the diagnostics range for [useAltText](https://biomejs.dev/linter/rules/use-alt-text), [useButtonType](https://biomejs.dev/linter/rules/use-button-type), [useHtmlLang](https://biomejs.dev/linter/rules/use-html-lang), [useIframeTitle](https://biomejs.dev/linter/rules/use-iframe-title), [useValidAriaRole](https://biomejs.dev/linter/rules/use-valid-aria-role) & [useIfameSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox) to report on the opening tag instead of the full tag. - [#10043](biomejs/biome#10043) [`fc65902`](biomejs/biome@fc65902) Thanks [@mujpao](https://github.com/mujpao)! - Fixed [#10003](biomejs/biome#10003): Biome no longer panics when parsing Svelte files containing `{#}`. - [#9815](biomejs/biome#9815) [`5cc83b1`](biomejs/biome@5cc83b1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`noLoopFunc`](https://biomejs.dev/linter/rules/no-loop-func/). When enabled, it warns when a function declared inside a loop captures outer variables that can change across iterations. - [#9702](biomejs/biome#9702) [`ef470ba`](biomejs/biome@ef470ba) Thanks [@ryan-m-walker](https://github.com/ryan-m-walker)! - Added the nursery rule [`useRegexpTest`](https://biomejs.dev/linter/rules/use-regexp-test/) that enforces `RegExp.prototype.test()` over `String.prototype.match()` and `RegExp.prototype.exec()` in boolean contexts. `test()` returns a boolean directly, avoiding unnecessary computation of match results. **Invalid** ```js if ("hello world".match(/hello/)) { } ``` **Valid** ```js if (/hello/.test("hello world")) { } ``` - [#9743](biomejs/biome#9743) [`245307d`](biomejs/biome@245307d) Thanks [@leetdavid](https://github.com/leetdavid)! - Fixed [#2245](biomejs/biome#2245): Svelte `<script>` tag language detection when the `generics` attribute contains `>` characters (e.g., `<script lang="ts" generics="T extends Record<string, unknown>">`). Biome now correctly recognizes TypeScript in such script blocks. - [#10046](biomejs/biome#10046) [`0707de7`](biomejs/biome@0707de7) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10038](biomejs/biome#10038): [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) now sorts imports in TypeScript modules and declaration files. ```diff declare module "mymodule" { - import type { B } from "b"; import type { A } from "a"; + import type { B } from "b"; } ``` - [#10012](biomejs/biome#10012) [`94ccca9`](biomejs/biome@94ccca9) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeLiteralColors`](https://biomejs.dev/linter/rules/no-react-native-literal-colors/), which disallows color literals inside React Native styles. The rule belongs to the `reactNative` domain. It reports properties whose name contains `color` and whose value is a string literal when they appear inside a `StyleSheet.create(...)` call or inside a JSX attribute whose name contains `style`. ```jsx // Invalid const Hello = () => <Text style={{ backgroundColor: "#FFFFFF" }}>hi</Text>; const styles = StyleSheet.create({ text: { color: "red" }, }); ``` ```jsx // Valid const red = "#f00"; const styles = StyleSheet.create({ text: { color: red }, }); ``` - [#10005](biomejs/biome#10005) [`131019e`](biomejs/biome@131019e) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeRawText`](https://biomejs.dev/linter/rules/no-react-native-raw-text/), which disallows raw text outside of `<Text>` components in React Native. The rule belongs to the new `reactNative` domain. ```jsx // Invalid <View>some text</View> <View>{'some text'}</View> ``` ```jsx // Valid <View> <Text>some text</Text> </View> ``` Additional components can be allowlisted through the `skip` option: ```json { "options": { "skip": ["Title"] } } ``` - [#9911](biomejs/biome#9911) [`1603f78`](biomejs/biome@1603f78) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noJsxLeakedDollar`](https://biomejs.dev/linter/rules/no-jsx-leaked-dollar), which flags text nodes with a trailing `$` if the next sibling node is a JSX expression. This could be an unintentional mistake, resulting in a '$' being rendered as text in the output. **Invalid**: ```jsx function MyComponent({ user }) { return <div>Hello ${user.name}</div>; } ``` - [#9999](biomejs/biome#9999) [`f42405f`](biomejs/biome@f42405f) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed `noMisleadingReturnType` incorrectly flagging functions with reassigned `let` variables. - [#10075](biomejs/biome#10075) [`295f97f`](biomejs/biome@295f97f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#9983`](biomejs/biome#9983): Biome now parses functions declared inside Svelte `#snippet` blocks without throwing errors. - [#10006](biomejs/biome#10006) [`cf4c1c9`](biomejs/biome@cf4c1c9) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): `noMisleadingReturnType` incorrectly flagging nested object literals with widened properties. - [#10033](biomejs/biome#10033) [`11ddc05`](biomejs/biome@11ddc05) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`useReactNativePlatformComponents`](https://biomejs.dev/linter/rules/use-react-native-platform-components/) that ensures platform-specific React Native components (e.g. `ProgressBarAndroid`, `ActivityIndicatorIOS`) are only imported in files with a matching platform suffix. It also reports when Android and iOS components are mixed in the same file. The following code triggers the rule when the file does not have an `.android.js` suffix: ```js // file.js import { ProgressBarAndroid } from "react-native"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/Cloudflared-Runner/pulls/4

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 22, 2026

coderabbitai Bot reviewed Apr 22, 2026

View reviewed changes

dyc3 reviewed Apr 22, 2026

View reviewed changes

Comment thread crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs

Comment thread crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs

dyc3 approved these changes Apr 22, 2026

View reviewed changes

dyc3 force-pushed the fix/no-useless-escape-regex-v-flag branch from 3b81f0e to b5eb25f Compare April 22, 2026 11:50

coderabbitai Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread crates/biome_js_analyze/src/lint/complexity/no_useless_escape_in_regex.rs

dyc3 force-pushed the fix/no-useless-escape-regex-v-flag branch from b5eb25f to c7f08c4 Compare April 22, 2026 13:24

jiwon79 and others added 5 commits April 22, 2026 11:25

chore: add changeset for noUselessEscapeInRegex v-flag fix

6ab31fd

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dyc3 force-pushed the fix/no-useless-escape-regex-v-flag branch from c7f08c4 to 65225f5 Compare April 22, 2026 15:25

dyc3 merged commit 5e2f90c into biomejs:main Apr 22, 2026
30 checks passed

github-actions Bot mentioned this pull request Apr 22, 2026

ci: release #9991

Merged

jiwon79 deleted the fix/no-useless-escape-regex-v-flag branch April 23, 2026 03:57

coderabbitai Bot mentioned this pull request Apr 26, 2026

fix(analyzer): noUselessEscapeInRegex no longer flags \\- as useless #10116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(analyzer): noUselessEscapeInRegex preserves required v-flag escapes#10084

fix(analyzer): noUselessEscapeInRegex preserves required v-flag escapes#10084
dyc3 merged 5 commits intobiomejs:mainfrom
jiwon79:fix/no-useless-escape-regex-v-flag

jiwon79 commented Apr 22, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

Reviews paused

Uh oh!

coderabbitai Bot left a comment

Uh oh!

jiwon79 commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jiwon79 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jiwon79 commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jiwon79 commented Apr 22, 2026 •

edited

Loading

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 22, 2026 •

edited

Loading