Skip to content

refactor: deduplicate common code in unit test lint rules#9395

Draft
dyc3 wants to merge 1 commit intographite-base/9395from
dyc3/refactor-unit-test-rules
Draft

refactor: deduplicate common code in unit test lint rules#9395
dyc3 wants to merge 1 commit intographite-base/9395from
dyc3/refactor-unit-test-rules

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Mar 8, 2026

Summary

The goal was to simplify the implementations of these rules, and avoid allocating Vecs when just iterating over unit test functions.

Test Plan

snapshots

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 8, 2026

⚠️ No Changeset found

Latest commit: e1cbcb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor Author

dyc3 commented Mar 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dyc3 dyc3 force-pushed the dyc3/refactor-unit-test-rules branch from e47f017 to e1cbcb9 Compare March 8, 2026 16:21
@nidhishgajjar

This comment was marked as spam.

@dyc3 dyc3 changed the base branch from dyc3/use-test-hooks-in-order to graphite-base/9395 April 25, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants