This repository was archived by the owner on Mar 9, 2019. It is now read-only.
db: fix recovery from unsynced metadata#555
Merged
benbjohnson merged 1 commit intoboltdb:masterfrom Apr 24, 2016
cyphar:548-fix-errors-with-unsynced-metadata
Merged
db: fix recovery from unsynced metadata#555benbjohnson merged 1 commit intoboltdb:masterfrom cyphar:548-fix-errors-with-unsynced-metadata
benbjohnson merged 1 commit intoboltdb:masterfrom
cyphar:548-fix-errors-with-unsynced-metadata
Conversation
Bolt stores the two latest transactions' metadata, but previously did not recover from validation failures in the latest by using the second latest. Fix this by correctly handling validation failures in db.go, as well as returning the metadata with highest txid which is also valid in DB.meta(). Signed-off-by: Aleksa Sarai <asarai@suse.de>
Member
Closed
|
Is it safe to assume that the tests added will catch a regression if this type of crash (and corruption) occurs again? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bolt stores the two latest transactions' metadata, but previously did
not recover from validation failures in the latest by using the second
latest. Fix this by correctly handling validation failures in db.go, as
well as returning the metadata with highest txid which is also valid in
DB.meta().
Fixes: #548
Signed-off-by: Aleksa Sarai asarai@suse.de
/cc @benbjohnson