Skip to content

gpg encryption support#162

Merged
francescayeye merged 18 commits into
mainfrom
gpg-encryption-support
Mar 11, 2023
Merged

gpg encryption support#162
francescayeye merged 18 commits into
mainfrom
gpg-encryption-support

Conversation

@francescayeye

Copy link
Copy Markdown
Collaborator

X-Encrypt-Password/X-Decrypt-Password headers work seemingless as in gpg piping shell examples

@francescayeye francescayeye requested a review from nl5887 October 6, 2018 17:07
@francescayeye

Copy link
Copy Markdown
Collaborator Author
  • missing tests
  • missing updated doc

@francescayeye francescayeye removed the request for review from nl5887 August 22, 2021 16:24
@JacksonChen666

JacksonChen666 commented Dec 16, 2021

Copy link
Copy Markdown

the idea of the server managing the encryption instead of the client makes it not end to end encrypted, plus the password could be read by the server anyways.
while it is encrypted at rest, there is nothing preventing the servers from reading the headers for the password. there's also nothing preventing the server from not encrypting at all.
so, if you want encryption for secret stuff, encrypt it before you even send it to the server.

@francescayeye

Copy link
Copy Markdown
Collaborator Author

@stefanbenten what do you think of this?
I've refectored in order to use a maintained opengpg library

@francescayeye francescayeye added reviewer-can-merge This Pull Request is fine to merge after approval. and removed wip labels Sep 12, 2022
@francescayeye francescayeye added wip and removed reviewer-can-merge This Pull Request is fine to merge after approval. labels Sep 12, 2022
@francescayeye francescayeye removed the wip label Sep 14, 2022
do not reference server public hosting version in encrypt/decrypt headers example
@stefanbenten

Copy link
Copy Markdown
Collaborator

I'll review this today :)

@francescayeye

Copy link
Copy Markdown
Collaborator Author

@stefanbenten did you have a chance to review?
I'd like to merge it

@stefanbenten stefanbenten left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small code styling comments, overall looks good.
Will do a staging test now, if you do not hear from me until midnight UTC, assume it worked :)

Comment thread server/handlers.go
Comment thread server/handlers.go
@raziman18

Copy link
Copy Markdown

Has this been tested yet?

@francescayeye

Copy link
Copy Markdown
Collaborator Author

Has this been tested yet?

going to merge soon

@francescayeye

Copy link
Copy Markdown
Collaborator Author

indeed will wait #527 before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants