feat(tag): new component#203
Merged
BrandonRomano merged 5 commits intoghostty-org:mainfrom Dec 28, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
BrandonRomano
requested changes
Dec 28, 2024
Member
BrandonRomano
left a comment
There was a problem hiding this comment.
Nice this is looking good! We'll need the key; the other change is a suggestion!
BrandonRomano
approved these changes
Dec 28, 2024
Member
BrandonRomano
left a comment
There was a problem hiding this comment.
Love it! I added one small code suggestion (I'll probably just add this and merge it!)
Member
|
Thanks @DeadEnglish this is great 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What doe this do?
For #125, we need a
Tagcomponent that will be used to display tags associated to the showcase on display. This is a quick implementation using all the brand & atom colours. Future improvement of aghostprop (no background colour, just the border) but will look into it if we need it once the page is complete.FWIW there's probably some accessibility issues with the background/text colours but can be fixed later.
Code usage
Images/video