Fix area weighting in polygon geometric center calculation#119167
Open
red-bean-pasta wants to merge 1 commit into
Open
Fix area weighting in polygon geometric center calculation#119167red-bean-pasta wants to merge 1 commit into
red-bean-pasta wants to merge 1 commit into
Conversation
f01556d to
a7abef8
Compare
YeldhamDev
approved these changes
May 5, 2026
jak6jak
added a commit
to jak6jak-experiment/godot
that referenced
this pull request
May 19, 2026
…geometric center calculation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractPolygon2DEditor::_get_geometric_center()calculated the centroid of each sub-polygon, but then averaged those centroids equally. This may produce incorrect result when the sub-polygons have different areas.This PR changes the final centroid calculation to use area-weighted average.
After / Before:
