macOS crash handler: Move symbolize with atos to its own function#119305
Open
aaronfranke wants to merge 1 commit into
Open
macOS crash handler: Move symbolize with atos to its own function#119305aaronfranke wants to merge 1 commit into
aaronfranke wants to merge 1 commit into
Conversation
bruvzg
approved these changes
May 8, 2026
428d255 to
9d991d9
Compare
jak6jak
added a commit
to jak6jak-experiment/godot
that referenced
this pull request
May 19, 2026
…olize with atos to its own function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to PR #118642, this PR pulls another chunk out of PR #64205 in an attempt to make it easier to review.
This PR extracts the symbolize with atos logic to its own function, and moves it to a new
stack_trace_macos.hfile, which contains a newStackTraceMacOSnamespace. The find executable load address function was also moved here.Also, as a bonus, I renamed
_execpathtoexec_pathto match the naming convention for local variables, and did the same thing in the LinuxBSD and Windows code.