Ensure that BPTC LayeredTexture images get compressed with same signedness#119598
Open
nikitalita wants to merge 1 commit into
Open
Ensure that BPTC LayeredTexture images get compressed with same signedness#119598nikitalita wants to merge 1 commit into
nikitalita wants to merge 1 commit into
Conversation
Member
|
@BlueCube3310 If you have some time can you look into this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Additional information
This fixes the issue by running
detect_signed()on the whole image before saving it as compressed textures, and then passing in the signedness as a parameter toImage::_compress_from_channels()I added
Image::_compress_from_channels()to the Image class for this because I did not want to modify the public API and I don't think it's necessary for the BPTC option functionality to be exposed; let me know if you want me to modifycompress()to expose that.