This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Make ServiceApiSettings provider interfaces public - #75
Merged
Conversation
Make ChannelProvider, ExecutorProvider and CredentialsProvider interfaces public. This allows the ApiSettings object to be constructed without instantiating the channel, executor or credentials until they are required by the Api object. Pre-push hook installed. Change-Id: I2b88beb112c24e8e35d5d58b4883bd4be0d15706
Pre-push hook installed. Change-Id: I6742fae6a8b1052ba1d5a9fc6bcebb90fa87cd7e
| * service. | ||
| */ | ||
| interface CredentialsProvider { | ||
| public interface CredentialsProvider { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Moved interfaces to separate files Added shouldAutoClose parameter to ExecutorProvider Added OperationNotSupportedException to ExecutorProvider and ChannelProvider when a fixed executor/channel is accessed multiple times. Updated documentation Pre-push hook installed. Change-Id: Icb29408ad0854908932675723a2cc831d0111949
Removed exceptions not thrown Updated params in javadocs Fixed broken doc links Pre-push hook installed. Change-Id: I2a259ea65dd9a9094a67fdf8d78ad820abf3d7e2
Contributor
Author
|
PTAL |
| * | ||
| * If the {@link ExecutorProvider} is configured to return a fixed | ||
| * {@link ScheduledExecutorService} object and to return shouldAutoClose as true, then after the | ||
| * first call to {@link #getExecutor}, subsequent calls should throw an {@link ExecutorProvider}. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Changed OperationNotSupportedException to IllegalStateException Fixed doc errors Pre-push hook installed. Change-Id: I33529e918b1e22ce643c03dd46f207a16adfe8ad
Contributor
Author
|
PTAL |
Added unit tests Removed getOrBuild methods Set executorProvider in ServiceApiSettings constructor Pre-push hook installed. Change-Id: I193be2e6a6ad2e35b5f1def5182e19d9dc14ab29
| * acquired yet, then they will be acquired when this function is called. | ||
| */ | ||
| public Credentials getCredentials() throws IOException { | ||
| public Credentials getOrBuildCredentials() throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Pre-push hook installed. Change-Id: Icd5d157d0d164f8eb2536778fbafbea7c5c546a2
Pre-push hook installed. Change-Id: I10039ae000dae902b30a9df43fdd5c1316191281
Contributor
Author
|
PTAL |
|
|
||
| /** | ||
| * Get the channel to be used to connect to the service. The first time this is called, if the | ||
| * channel does not already exist, it will be created. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Pre-push hook installed. Change-Id: I4ca6d7d72ad1941846bb9afcb68ee7d518317e3a
Contributor
Author
|
PTAL |
Contributor
|
LGTM |
This was referenced May 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ChannelProvider, ExecutorProvider and CredentialsProvider
interfaces public. This allows the ApiSettings object to be
constructed without instantiating the channel, executor or
credentials until they are required by the Api object.