fix(storage): migrate oauth2/google usages to cloud.google.com/go/auth - #11191
Merged
Conversation
quartzmo
force-pushed
the
storage-new-auth
branch
from
November 26, 2024 00:24
cbc450e to
2f8457f
Compare
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Nov 26, 2024
quartzmo
added a commit
to quartzmo/google-api-go-client
that referenced
this pull request
Nov 26, 2024
quartzmo
added a commit
to googleapis/google-api-go-client
that referenced
this pull request
Nov 26, 2024
BrennaEpp
reviewed
Dec 4, 2024
BrennaEpp
left a comment
Contributor
There was a problem hiding this comment.
In general looks good, thank you for the changes. Just a note on making sure tests pass with old auth creds sent in by users.
quartzmo
commented
Mar 6, 2025
| // Don't error out here. The user may have passed in their own HTTP | ||
| // client which does not auth with ADC or other common conventions. | ||
| c, err := transport.Creds(ctx, opts...) | ||
| c, err := internaloption.AuthCreds(ctx, opts) |
Member
Author
There was a problem hiding this comment.
Does internaloption.EnableNewAuthLibrary() need to be added here (or elsewhere)?
Contributor
There was a problem hiding this comment.
I don't think so, internaloption.AuthCreds(ctx, opts) will call into the new auth library no matter what it seems. What maybe should be added is a check for the env var to disable new auth if we still need that in case we need to debug?
Co-authored-by: Brenna N Epp <brennanatashaepp@gmail.com>
quartzmo
marked this pull request as ready for review
April 11, 2025 22:08
Contributor
|
Just adding a note here, integration tests pass on the latest commit to this PR. |
BrennaEpp
approved these changes
May 2, 2025
BrennaEpp
enabled auto-merge (squash)
May 14, 2025 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended as a replacement for #11121. It uses a new internaloption.AuthCreds helper func added to the
google.golang.org/api/optionpackage to support sourcing credentials from both old and new auth options. You can see that helper here: googleapis/google-api-go-client#2891.