Skip to content

feat: add skip_backlog field to allow subscriptions to be created at HEAD #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannahrogers-google merged 2 commits into from
Mar 8, 2021
Merged

feat: add skip_backlog field to allow subscriptions to be created at HEAD #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b90d8
feat: add skip_backlog field to allow subscriptions to be created at …
yoshi-automation Mar 8, 2021
e48597b
chore: update gax-java dependency to 1.62
yoshi-automation Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/AdminServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,7 @@ public final Subscription createSubscription(
* .setParent(LocationName.of("[PROJECT]", "[LOCATION]").toString())
* .setSubscription(Subscription.newBuilder().build())
* .setSubscriptionId("subscriptionId1478790936")
* .setSkipBacklog(true)
* .build();
* Subscription response = adminServiceClient.createSubscription(request);
* }
Expand All @@ -1001,6 +1002,7 @@ public final Subscription createSubscription(CreateSubscriptionRequest request)
* .setParent(LocationName.of("[PROJECT]", "[LOCATION]").toString())
* .setSubscription(Subscription.newBuilder().build())
* .setSubscriptionId("subscriptionId1478790936")
* .setSkipBacklog(true)
* .build();
* ApiFuture<Subscription> future =
* adminServiceClient.createSubscriptionCallable().futureCall(request);
Expand Down
16 changes: 8 additions & 8 deletions ...loud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/TopicStatsServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,10 @@ public final ComputeMessageStatsResponse computeMessageStats(ComputeMessageStats

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Compute the head cursor for the partition. The head cursor?s offset is guaranteed to be before
* or equal to all messages which have not yet been acknowledged to be published, and greater than
* the offset of any message whose publish has already been acknowledged. It is 0 if there have
* never been messages on the partition.
* Compute the head cursor for the partition. The head cursor's offset is guaranteed to be less
* than or equal to all messages which have not yet been acknowledged as published, and greater
* than the offset of any message whose publish has already been acknowledged. It is zero if there
* have never been messages in the partition.
*
* <p>Sample code:
*
Expand All @@ -233,10 +233,10 @@ public final ComputeHeadCursorResponse computeHeadCursor(ComputeHeadCursorReques

// AUTO-GENERATED DOCUMENTATION AND METHOD.
/**
* Compute the head cursor for the partition. The head cursor?s offset is guaranteed to be before
* or equal to all messages which have not yet been acknowledged to be published, and greater than
* the offset of any message whose publish has already been acknowledged. It is 0 if there have
* never been messages on the partition.
* Compute the head cursor for the partition. The head cursor's offset is guaranteed to be less
* than or equal to all messages which have not yet been acknowledged as published, and greater
* than the offset of any message whose publish has already been acknowledged. It is zero if there
* have never been messages in the partition.
*
* <p>Sample code:
*
Expand Down
142 changes: 77 additions & 65 deletions ...cloud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/AdminServiceGrpc.java
View file
Open in desktop

Large diffs are not rendered by default.

38 changes: 17 additions & 21 deletions ...loud-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/CursorServiceGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@
package com.google.cloud.pubsublite.proto;

import static io.grpc.MethodDescriptor.generateFullMethodName;
import static io.grpc.stub.ClientCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ClientCalls.asyncUnaryCall;
import static io.grpc.stub.ClientCalls.blockingUnaryCall;
import static io.grpc.stub.ClientCalls.futureUnaryCall;
import static io.grpc.stub.ServerCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncUnaryCall;
import static io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall;
import static io.grpc.stub.ServerCalls.asyncUnimplementedUnaryCall;

/**
*
Expand Down Expand Up @@ -255,7 +247,8 @@ public abstract static class CursorServiceImplBase implements io.grpc.BindableSe
io.grpc.stub.StreamObserver<
com.google.cloud.pubsublite.proto.StreamingCommitCursorResponse>
responseObserver) {
return asyncUnimplementedStreamingCall(getStreamingCommitCursorMethod(), responseObserver);
return io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall(
getStreamingCommitCursorMethod(), responseObserver);
}

/**
Expand All @@ -269,7 +262,8 @@ public void commitCursor(
com.google.cloud.pubsublite.proto.CommitCursorRequest request,
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.CommitCursorResponse>
responseObserver) {
asyncUnimplementedUnaryCall(getCommitCursorMethod(), responseObserver);
io.grpc.stub.ServerCalls.asyncUnimplementedUnaryCall(
getCommitCursorMethod(), responseObserver);
}

/**
Expand All @@ -283,29 +277,30 @@ public void listPartitionCursors(
com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest request,
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.ListPartitionCursorsResponse>
responseObserver) {
asyncUnimplementedUnaryCall(getListPartitionCursorsMethod(), responseObserver);
io.grpc.stub.ServerCalls.asyncUnimplementedUnaryCall(
getListPartitionCursorsMethod(), responseObserver);
}

@java.lang.Override
public final io.grpc.ServerServiceDefinition bindService() {
return io.grpc.ServerServiceDefinition.builder(getServiceDescriptor())
.addMethod(
getStreamingCommitCursorMethod(),
asyncBidiStreamingCall(
io.grpc.stub.ServerCalls.asyncBidiStreamingCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.StreamingCommitCursorRequest,
com.google.cloud.pubsublite.proto.StreamingCommitCursorResponse>(
this, METHODID_STREAMING_COMMIT_CURSOR)))
.addMethod(
getCommitCursorMethod(),
asyncUnaryCall(
io.grpc.stub.ServerCalls.asyncUnaryCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.CommitCursorRequest,
com.google.cloud.pubsublite.proto.CommitCursorResponse>(
this, METHODID_COMMIT_CURSOR)))
.addMethod(
getListPartitionCursorsMethod(),
asyncUnaryCall(
io.grpc.stub.ServerCalls.asyncUnaryCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest,
com.google.cloud.pubsublite.proto.ListPartitionCursorsResponse>(
Expand Down Expand Up @@ -347,7 +342,7 @@ protected CursorServiceStub build(io.grpc.Channel channel, io.grpc.CallOptions c
io.grpc.stub.StreamObserver<
com.google.cloud.pubsublite.proto.StreamingCommitCursorResponse>
responseObserver) {
return asyncBidiStreamingCall(
return io.grpc.stub.ClientCalls.asyncBidiStreamingCall(
getChannel().newCall(getStreamingCommitCursorMethod(), getCallOptions()),
responseObserver);
}
Expand All @@ -363,7 +358,7 @@ public void commitCursor(
com.google.cloud.pubsublite.proto.CommitCursorRequest request,
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.CommitCursorResponse>
responseObserver) {
asyncUnaryCall(
io.grpc.stub.ClientCalls.asyncUnaryCall(
getChannel().newCall(getCommitCursorMethod(), getCallOptions()),
request,
responseObserver);
Expand All @@ -380,7 +375,7 @@ public void listPartitionCursors(
com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest request,
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.ListPartitionCursorsResponse>
responseObserver) {
asyncUnaryCall(
io.grpc.stub.ClientCalls.asyncUnaryCall(
getChannel().newCall(getListPartitionCursorsMethod(), getCallOptions()),
request,
responseObserver);
Expand Down Expand Up @@ -417,7 +412,8 @@ protected CursorServiceBlockingStub build(
*/
public com.google.cloud.pubsublite.proto.CommitCursorResponse commitCursor(
com.google.cloud.pubsublite.proto.CommitCursorRequest request) {
return blockingUnaryCall(getChannel(), getCommitCursorMethod(), getCallOptions(), request);
return io.grpc.stub.ClientCalls.blockingUnaryCall(
getChannel(), getCommitCursorMethod(), getCallOptions(), request);
}

/**
Expand All @@ -429,7 +425,7 @@ public com.google.cloud.pubsublite.proto.CommitCursorResponse commitCursor(
*/
public com.google.cloud.pubsublite.proto.ListPartitionCursorsResponse listPartitionCursors(
com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest request) {
return blockingUnaryCall(
return io.grpc.stub.ClientCalls.blockingUnaryCall(
getChannel(), getListPartitionCursorsMethod(), getCallOptions(), request);
}
}
Expand Down Expand Up @@ -465,7 +461,7 @@ protected CursorServiceFutureStub build(
public com.google.common.util.concurrent.ListenableFuture<
com.google.cloud.pubsublite.proto.CommitCursorResponse>
commitCursor(com.google.cloud.pubsublite.proto.CommitCursorRequest request) {
return futureUnaryCall(
return io.grpc.stub.ClientCalls.futureUnaryCall(
getChannel().newCall(getCommitCursorMethod(), getCallOptions()), request);
}

Expand All @@ -480,7 +476,7 @@ protected CursorServiceFutureStub build(
com.google.cloud.pubsublite.proto.ListPartitionCursorsResponse>
listPartitionCursors(
com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest request) {
return futureUnaryCall(
return io.grpc.stub.ClientCalls.futureUnaryCall(
getChannel().newCall(getListPartitionCursorsMethod(), getCallOptions()), request);
}
}
Expand Down
10 changes: 4 additions & 6 deletions ...te-v1/src/main/java/com/google/cloud/pubsublite/proto/PartitionAssignmentServiceGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
package com.google.cloud.pubsublite.proto;

import static io.grpc.MethodDescriptor.generateFullMethodName;
import static io.grpc.stub.ClientCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall;

/**
*
Expand Down Expand Up @@ -156,15 +153,16 @@ public abstract static class PartitionAssignmentServiceImplBase
assignPartitions(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PartitionAssignment>
responseObserver) {
return asyncUnimplementedStreamingCall(getAssignPartitionsMethod(), responseObserver);
return io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall(
getAssignPartitionsMethod(), responseObserver);
}

@java.lang.Override
public final io.grpc.ServerServiceDefinition bindService() {
return io.grpc.ServerServiceDefinition.builder(getServiceDescriptor())
.addMethod(
getAssignPartitionsMethod(),
asyncBidiStreamingCall(
io.grpc.stub.ServerCalls.asyncBidiStreamingCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.PartitionAssignmentRequest,
com.google.cloud.pubsublite.proto.PartitionAssignment>(
Expand Down Expand Up @@ -210,7 +208,7 @@ protected PartitionAssignmentServiceStub build(
assignPartitions(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PartitionAssignment>
responseObserver) {
return asyncBidiStreamingCall(
return io.grpc.stub.ClientCalls.asyncBidiStreamingCall(
getChannel().newCall(getAssignPartitionsMethod(), getCallOptions()), responseObserver);
}
}
Expand Down
10 changes: 4 additions & 6 deletions ...d-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/PublisherServiceGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
package com.google.cloud.pubsublite.proto;

import static io.grpc.MethodDescriptor.generateFullMethodName;
import static io.grpc.stub.ClientCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall;

/**
*
Expand Down Expand Up @@ -155,15 +152,16 @@ public abstract static class PublisherServiceImplBase implements io.grpc.Bindabl
public io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PublishRequest> publish(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PublishResponse>
responseObserver) {
return asyncUnimplementedStreamingCall(getPublishMethod(), responseObserver);
return io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall(
getPublishMethod(), responseObserver);
}

@java.lang.Override
public final io.grpc.ServerServiceDefinition bindService() {
return io.grpc.ServerServiceDefinition.builder(getServiceDescriptor())
.addMethod(
getPublishMethod(),
asyncBidiStreamingCall(
io.grpc.stub.ServerCalls.asyncBidiStreamingCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.PublishRequest,
com.google.cloud.pubsublite.proto.PublishResponse>(this, METHODID_PUBLISH)))
Expand Down Expand Up @@ -208,7 +206,7 @@ protected PublisherServiceStub build(io.grpc.Channel channel, io.grpc.CallOption
public io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PublishRequest> publish(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.PublishResponse>
responseObserver) {
return asyncBidiStreamingCall(
return io.grpc.stub.ClientCalls.asyncBidiStreamingCall(
getChannel().newCall(getPublishMethod(), getCallOptions()), responseObserver);
}
}
Expand Down
10 changes: 4 additions & 6 deletions ...-pubsublite-v1/src/main/java/com/google/cloud/pubsublite/proto/SubscriberServiceGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
package com.google.cloud.pubsublite.proto;

import static io.grpc.MethodDescriptor.generateFullMethodName;
import static io.grpc.stub.ClientCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncBidiStreamingCall;
import static io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall;

/**
*
Expand Down Expand Up @@ -147,15 +144,16 @@ public abstract static class SubscriberServiceImplBase implements io.grpc.Bindab
subscribe(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.SubscribeResponse>
responseObserver) {
return asyncUnimplementedStreamingCall(getSubscribeMethod(), responseObserver);
return io.grpc.stub.ServerCalls.asyncUnimplementedStreamingCall(
getSubscribeMethod(), responseObserver);
}

@java.lang.Override
public final io.grpc.ServerServiceDefinition bindService() {
return io.grpc.ServerServiceDefinition.builder(getServiceDescriptor())
.addMethod(
getSubscribeMethod(),
asyncBidiStreamingCall(
io.grpc.stub.ServerCalls.asyncBidiStreamingCall(
new MethodHandlers<
com.google.cloud.pubsublite.proto.SubscribeRequest,
com.google.cloud.pubsublite.proto.SubscribeResponse>(
Expand Down Expand Up @@ -195,7 +193,7 @@ protected SubscriberServiceStub build(
subscribe(
io.grpc.stub.StreamObserver<com.google.cloud.pubsublite.proto.SubscribeResponse>
responseObserver) {
return asyncBidiStreamingCall(
return io.grpc.stub.ClientCalls.asyncBidiStreamingCall(
getChannel().newCall(getSubscribeMethod(), getCallOptions()), responseObserver);
}
}
Expand Down
Loading