Skip to content

fix: create a hard failure when batching settings with flow control are used #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpcollins-google merged 2 commits into from
Jul 26, 2021
Merged

fix: create a hard failure when batching settings with flow control are used #758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e6c00e
fix: create a hard failure when invalid batching settings are set
dpcollins-google Jul 26, 2021
e0de0aa
fix: reformat
dpcollins-google Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...d-pubsublite/src/main/java/com/google/cloud/pubsublite/cloudpubsub/PublisherSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.api.gax.batching.BatchingSettings;
import com.google.api.gax.core.CredentialsProvider;
import com.google.api.gax.rpc.ApiException;
import com.google.api.gax.rpc.StatusCode.Code;
import com.google.auto.value.AutoValue;
import com.google.cloud.pubsublite.AdminClient;
import com.google.cloud.pubsublite.AdminClientSettings;
Expand All @@ -32,6 +33,7 @@
import com.google.cloud.pubsublite.Partition;
import com.google.cloud.pubsublite.TopicPath;
import com.google.cloud.pubsublite.cloudpubsub.internal.WrappingPublisher;
import com.google.cloud.pubsublite.internal.CheckedApiException;
import com.google.cloud.pubsublite.internal.wire.PartitionCountWatchingPublisherSettings;
import com.google.cloud.pubsublite.internal.wire.PubsubContext;
import com.google.cloud.pubsublite.internal.wire.PubsubContext.Framework;
Expand Down Expand Up @@ -185,6 +187,13 @@ private AdminClient getAdminClient() throws ApiException {
@SuppressWarnings("CheckReturnValue")
Publisher instantiate() throws ApiException {
BatchingSettings batchingSettings = batchingSettings().orElse(DEFAULT_BATCHING_SETTINGS);
if (batchingSettings.getFlowControlSettings().getMaxOutstandingElementCount() != null
|| batchingSettings.getFlowControlSettings().getMaxOutstandingRequestBytes() != null) {
throw new CheckedApiException(
"Pub/Sub Lite does not support flow control settings for publishing.",
Code.INVALID_ARGUMENT)
.underlying;
}
KeyExtractor keyExtractor = keyExtractor().orElse(KeyExtractor.DEFAULT);
MessageTransformer<PubsubMessage, Message> messageTransformer =
messageTransformer()
Expand Down