feat: introduce RPC CancelResumableWriteRequest - #1518
Merged
Conversation
docs: Clarify that IAM RPCs apply to buckets as well as objects feat!: Removed upload_id from DeleteObjectRequest, and in its place defined separate CancelResumableWriteRequest RPC feat: Added optional object_size to WriteObjectSpec, as constraint on object being written docs: Clarified project ID format of various RPCs docs: Clarified behavior of update_mask in UpdateHmacKeyRequest docs: Clarified meaning/behavior of fields in HmacKeyMetadata docs: Clarified cases where update_time is updated in Bucket message docs: Clarified UpdateHmacKeyRequest.update_mask behavior docs: Clarified meaning of <projectIdentifier> for several RPCs PiperOrigin-RevId: 461979598 Source-Link: googleapis/googleapis@2938d54 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2bc85c2e00bb3ef8f5aaccf343b0d9428d4dc3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJiYzg1YzJlMDBiYjNlZjhmNWFhY2NmMzQzYjBkOTQyOGQ0ZGMzZCJ9
lqiu96
previously approved these changes
Jul 20, 2022
BenWhitehead
dismissed
lqiu96’s stale review
July 20, 2022 15:26
I need to do an in depth code review of these generated changes
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Allow removal of DeleteObjectRequest.upload_id Allow addition of WriteObjectSpec.object_size
BenWhitehead
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: Clarify that IAM RPCs apply to buckets as well as objects
feat!: Removed upload_id from DeleteObjectRequest, and in its place defined separate CancelResumableWriteRequest RPC
feat: Added optional object_size to WriteObjectSpec, as constraint on object being written
docs: Clarified project ID format of various RPCs
docs: Clarified behavior of update_mask in UpdateHmacKeyRequest
docs: Clarified meaning/behavior of fields in HmacKeyMetadata
docs: Clarified cases where update_time is updated in Bucket message
docs: Clarified UpdateHmacKeyRequest.update_mask behavior
docs: Clarified meaning of for several RPCs
PiperOrigin-RevId: 461979598
Source-Link: googleapis/googleapis@2938d54
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2bc85c2e00bb3ef8f5aaccf343b0d9428d4dc3d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJiYzg1YzJlMDBiYjNlZjhmNWFhY2NmMzQzYjBkOTQyOGQ0ZGMzZCJ9