Skip to content

docs: Updated ChecksummedData message definition to specify ctype=CORD, and removed incorrect earlier attempt that set that annotation in the ReadObjectResponse message definition #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWhitehead merged 2 commits into from
Mar 30, 2023
Merged

docs: Updated ChecksummedData message definition to specify ctype=CORD, and removed incorrect earlier attempt that set that annotation in the ReadObjectResponse message definition #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6da37
docs: Updated ChecksummedData message definition to specify ctype=COR…
gcf-owl-bot[bot] Mar 30, 2023
ea21b84
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2200,6 +2200,11 @@ public final UnaryCallable<DeleteObjectRequest, Empty> deleteObjectCallable() {
/**
* Cancels an in-progress resumable upload.
*
* <p>Any attempts to write to the resumable upload after cancelling the upload will fail.
*
* <p>The behavior for currently in progress write operations is not guaranteed - they could
* either complete before the cancellation or fail if the cancellation completes first.
*
* <p>Sample code:
*
* <pre>{@code
Expand Down Expand Up @@ -2228,6 +2233,11 @@ public final CancelResumableWriteResponse cancelResumableWrite(String uploadId)
/**
* Cancels an in-progress resumable upload.
*
* <p>Any attempts to write to the resumable upload after cancelling the upload will fail.
*
* <p>The behavior for currently in progress write operations is not guaranteed - they could
* either complete before the cancellation or fail if the cancellation completes first.
*
* <p>Sample code:
*
* <pre>{@code
Expand Down Expand Up @@ -2255,6 +2265,11 @@ public final CancelResumableWriteResponse cancelResumableWrite(
/**
* Cancels an in-progress resumable upload.
*
* <p>Any attempts to write to the resumable upload after cancelling the upload will fail.
*
* <p>The behavior for currently in progress write operations is not guaranteed - they could
* either complete before the cancellation or fail if the cancellation completes first.
*
* <p>Sample code:
*
* <pre>{@code
Expand Down
20 changes: 20 additions & 0 deletions grpc-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,6 +1613,11 @@ default void deleteObject(
*
* <pre>
* Cancels an in-progress resumable upload.
* Any attempts to write to the resumable upload after cancelling the upload
* will fail.
* The behavior for currently in progress write operations is not guaranteed -
* they could either complete before the cancellation or fail if the
* cancellation completes first.
* </pre>
*/
default void cancelResumableWrite(
Expand Down Expand Up @@ -2209,6 +2214,11 @@ public void deleteObject(
*
* <pre>
* Cancels an in-progress resumable upload.
* Any attempts to write to the resumable upload after cancelling the upload
* will fail.
* The behavior for currently in progress write operations is not guaranteed -
* they could either complete before the cancellation or fail if the
* cancellation completes first.
* </pre>
*/
public void cancelResumableWrite(
Expand Down Expand Up @@ -2751,6 +2761,11 @@ public com.google.protobuf.Empty deleteObject(
*
* <pre>
* Cancels an in-progress resumable upload.
* Any attempts to write to the resumable upload after cancelling the upload
* will fail.
* The behavior for currently in progress write operations is not guaranteed -
* they could either complete before the cancellation or fail if the
* cancellation completes first.
* </pre>
*/
public com.google.storage.v2.CancelResumableWriteResponse cancelResumableWrite(
Expand Down Expand Up @@ -3200,6 +3215,11 @@ protected StorageFutureStub build(io.grpc.Channel channel, io.grpc.CallOptions c
*
* <pre>
* Cancels an in-progress resumable upload.
* Any attempts to write to the resumable upload after cancelling the upload
* will fail.
* The behavior for currently in progress write operations is not guaranteed -
* they could either complete before the cancellation or fail if the
* cancellation completes first.
* </pre>
*/
public com.google.common.util.concurrent.ListenableFuture<
Expand Down
8 changes: 4 additions & 4 deletions proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/ChecksummedData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
* The data.
* </pre>
*
* <code>bytes content = 1;</code>
* <code>bytes content = 1 [ctype = CORD];</code>
*
* @return The content.
*/
Expand Down Expand Up @@ -496,7 +496,7 @@ public Builder mergeFrom(
* The data.
* </pre>
*
* <code>bytes content = 1;</code>
* <code>bytes content = 1 [ctype = CORD];</code>
*
* @return The content.
*/
Expand All @@ -511,7 +511,7 @@ public com.google.protobuf.ByteString getContent() {
* The data.
* </pre>
*
* <code>bytes content = 1;</code>
* <code>bytes content = 1 [ctype = CORD];</code>
*
* @param value The content to set.
* @return This builder for chaining.
Expand All @@ -532,7 +532,7 @@ public Builder setContent(com.google.protobuf.ByteString value) {
* The data.
* </pre>
*
* <code>bytes content = 1;</code>
* <code>bytes content = 1 [ctype = CORD];</code>
*
* @return This builder for chaining.
*/
Expand Down
2 changes: 1 addition & 1 deletion ...google-cloud-storage-v2/src/main/java/com/google/storage/v2/ChecksummedDataOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public interface ChecksummedDataOrBuilder
* The data.
* </pre>
*
* <code>bytes content = 1;</code>
* <code>bytes content = 1 [ctype = CORD];</code>
*
* @return The content.
*/
Expand Down
24 changes: 12 additions & 12 deletions proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/ReadObjectResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return Whether the checksummedData field is set.
*/
Expand All @@ -95,7 +95,7 @@ public boolean hasChecksummedData() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return The checksummedData.
*/
Expand All @@ -115,7 +115,7 @@ public com.google.storage.v2.ChecksummedData getChecksummedData() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
@java.lang.Override
public com.google.storage.v2.ChecksummedDataOrBuilder getChecksummedDataOrBuilder() {
Expand Down Expand Up @@ -744,7 +744,7 @@ public Builder mergeFrom(
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return Whether the checksummedData field is set.
*/
Expand All @@ -761,7 +761,7 @@ public boolean hasChecksummedData() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return The checksummedData.
*/
Expand All @@ -784,7 +784,7 @@ public com.google.storage.v2.ChecksummedData getChecksummedData() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public Builder setChecksummedData(com.google.storage.v2.ChecksummedData value) {
if (checksummedDataBuilder_ == null) {
Expand All @@ -809,7 +809,7 @@ public Builder setChecksummedData(com.google.storage.v2.ChecksummedData value) {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public Builder setChecksummedData(
com.google.storage.v2.ChecksummedData.Builder builderForValue) {
Expand All @@ -832,7 +832,7 @@ public Builder setChecksummedData(
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public Builder mergeChecksummedData(com.google.storage.v2.ChecksummedData value) {
if (checksummedDataBuilder_ == null) {
Expand Down Expand Up @@ -860,7 +860,7 @@ public Builder mergeChecksummedData(com.google.storage.v2.ChecksummedData value)
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public Builder clearChecksummedData() {
bitField0_ = (bitField0_ & ~0x00000001);
Expand All @@ -882,7 +882,7 @@ public Builder clearChecksummedData() {
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public com.google.storage.v2.ChecksummedData.Builder getChecksummedDataBuilder() {
bitField0_ |= 0x00000001;
Expand All @@ -899,7 +899,7 @@ public com.google.storage.v2.ChecksummedData.Builder getChecksummedDataBuilder()
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
public com.google.storage.v2.ChecksummedDataOrBuilder getChecksummedDataOrBuilder() {
if (checksummedDataBuilder_ != null) {
Expand All @@ -920,7 +920,7 @@ public com.google.storage.v2.ChecksummedDataOrBuilder getChecksummedDataOrBuilde
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
private com.google.protobuf.SingleFieldBuilderV3<
com.google.storage.v2.ChecksummedData,
Expand Down
6 changes: 3 additions & 3 deletions ...gle-cloud-storage-v2/src/main/java/com/google/storage/v2/ReadObjectResponseOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public interface ReadObjectResponseOrBuilder
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return Whether the checksummedData field is set.
*/
Expand All @@ -48,7 +48,7 @@ public interface ReadObjectResponseOrBuilder
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*
* @return The checksummedData.
*/
Expand All @@ -63,7 +63,7 @@ public interface ReadObjectResponseOrBuilder
* generate more data.
* </pre>
*
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1 [ctype = CORD];</code>
* <code>.google.storage.v2.ChecksummedData checksummed_data = 1;</code>
*/
com.google.storage.v2.ChecksummedDataOrBuilder getChecksummedDataOrBuilder();

Expand Down
Loading