Various cleanups from anguslees@#1
Merged
Merged
Conversation
Split channel sender and receiver into two clear owners. Replace sync crossbeam with async tokio channels, so we don't hold a synchronous lock over async await. Simplify applier start/stop lifecycle with RAII pattern (could do more here). Pass owned `echo::Manager` to `apply_async` rather than `Arc` reference. Use `?` operator and early-return to refactor some deeply nested code, particularly in `server::handle_request`. `Notifier`: Replace async `RwLock<>` with simpler sync `Arc<Mutex<>>` because these locks don't need to be held over async await. `echo::Manager`: Use ownership (`&mut`) to assert mutual exclusion rather than a lock. `echo::Request`: Treat omitted `message` as equivalent to `message == ""`, to better match golang `omitempty` semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More idiomatic Rust :)
Split channel sender and receiver into two clear owners.
Replace sync crossbeam with async tokio channels, so we don't hold a
synchronous lock over async await.
Simplify applier start/stop lifecycle with RAII pattern (could do more here).
Pass owned
echo::Managertoapply_asyncrather thanArcreference.Use
?operator and early-return to refactor some deeply nested code,particularly in
server::handle_request.Notifier: Replace asyncRwLock<>with simpler syncArc<Mutex<>>because these locks don't need to be held over async await.
echo::Manager: Use ownership (&mut) to assert mutual exclusionrather than a lock.
echo::Request: Treat omittedmessageas equivalent tomessage == "", to better match golangomitemptysemantics.