Conversation
Migrates from Jest to mocha and node's own `assert` library. Also updates ESLint to 9.x and bumps TSESLint to do the same.
wooorm
approved these changes
Jan 21, 2025
AriPerkkio
reviewed
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to figure out how to use
includeto select coverage rather than having to individuallyexcludeeverything before merging. but it isn't a blockerpossible alternative to #1268
vitest seems to produce better coverage somehow. i couldn't figure out why mocha/c8 was falling over