fix(install-rknpu): verify librknnrt version from temp file (closes #406)#420
Conversation
) Reported by redkjuegos — first run reports 'librknnrt version after install is ""' even though SHA256 verified. Re-running succeeds. Diagnosis filed in #406: filesystem-cache / symlink-resolution race window between 'sudo install' + 'sudo ldconfig' and 'strings <installed>'. The content IS correct (SHA256 matched up front); 'strings' just returns empty at that exact moment. Fix: verify against the temp source file before deleting it. The SHA256 check passed earlier so the temp file is provably correct. Falls back to re-reading the installed path if the temp is gone (e.g. a future caller restructures the flow), preserving the original verification strictness. Closes #406.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. â How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. đĻ How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. âšī¸ Review infoâī¸ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: đ Files selected for processing (1)
⨠Finishing Touchesđ§Ē Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-code-fast-1:optimized:free · 87,668 tokens |
Closes #406. Verify reads from the SHA256-verified temp source file before deletion instead of re-reading the just-installed path that hits a filesystem-cache race window. Falls back to re-read if temp is gone, preserving strictness.
Jay is asleep right now so this PR was opened by Claude Opus 4.7.