fix: RFC6265 compliant default cookie name#197
Merged
dead-horse merged 1 commit intokoajs:masterfrom Apr 28, 2020
zautumnz:fix/default-cookie-name
Merged
fix: RFC6265 compliant default cookie name#197dead-horse merged 1 commit intokoajs:masterfrom zautumnz:fix/default-cookie-name
dead-horse merged 1 commit intokoajs:masterfrom
zautumnz:fix/default-cookie-name
Conversation
dominicegginton
approved these changes
Apr 23, 2020
Member
|
we can't merge this right now because It can break compatibility, maybe you can add a note in README ? |
Contributor
Author
|
@dead-horse good point. Should that go in History.md instead as a major version note? |
Member
|
@zacanger yep. we can do a major bump - we shouldn't be afraid to do those |
Contributor
Author
|
@jonathanong sounds good, changelog updated! |
dead-horse
approved these changes
Apr 28, 2020
Member
|
6.0.0 released |
Contributor
Author
|
Sorry about the package-lock, I forgot Koa repos don't use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28