fix cluster-info dump error by ChiuWang · Pull Request #66652 · kubernetes/kubernetes

ChiuWang · 2018-07-26T08:20:27Z

Which issue(s) this PR fixes :
Fixes #65221

Release note:

fix cluster-info dump error

ChiuWang · 2018-07-26T08:21:45Z

/assign @juanvallejo

ChiuWang · 2018-07-28T01:34:08Z

@juanvallejo @deads2k PTAL 😸

CaoShuFeng · 2018-07-30T01:16:13Z

/ok-to-test

ChiuWang · 2018-07-30T02:04:59Z

/test pull-kubernetes-integration

ChiuWang · 2018-07-30T03:12:59Z

/test pull-kubernetes-e2e-gce-100-performance

juanvallejo · 2018-08-01T19:28:29Z

We should be using our printing stack, not circumventing it via special-cases in individual commands.
The overall problem appears to be that this command is sending internal objects to the printer.
These objects do not have a defined GroupVersionKind, so the printer refuses to print them.

To allow this command to work with the printer, we can re-work this command to work with external versions of objects: https://gist.github.com/juanvallejo/031d20ab40488c98c81b9928c5a5e753 (make sure you are up to date with latest master before applying)

@juanvallejo Thank you for your guidance. Work is done.

ming19871211 · 2018-08-02T01:57:23Z

Error while initializing connection to Kubernetes apiserver. This most likely means that the cluster is misconfigured (e.g., it has invalid apiserver certificates or service accounts configuration) or the --apiserver-host param points to a server that does not exist. Reason: Get https://10.96.0.1:443/version: dial tcp 10.96.0.1:443: i/o timeout
Refer to our FAQ and wiki pages for more information: https://github.com/kubernetes/dashboard/wiki/FAQ

juanvallejo · 2018-08-02T21:54:38Z

@charrywanganthony Thanks

/lgtm
cc @soltysh for approval

soltysh

Since you touched it, please update the client to use apps/v1

soltysh · 2018-08-03T12:31:07Z

I prefer CoreClient.

soltysh · 2018-08-03T12:32:47Z

DaemonSet, ReplicaSet and Deployment are part of apps/v1 since 1.10 at least. It's about time we switch commands to use the GA version.

@charrywanganthony You'd need to switch out extensionsv1client for appsv1client "github.com/openshift/client-go/apps/clientset/versioned/typed/apps/v1"

@juanvallejo WIP but openshift/client-go seems only have function for deployment func (c *AppsV1Client) DeploymentConfigs(namespace string) did i miss something?

@charrywanganthony sorry about that, the actual import path for the appsv1 client is "k8s.io/client-go/kubernetes/typed/apps/v1"

@juanvallejo @soltysh modified.

juanvallejo · 2018-08-08T13:55:24Z

/lgtm

soltysh

/lgtm
/approve

soltysh · 2018-08-09T11:33:38Z

Similarly AppsClient is the preferred name.

ChiuWang · 2018-08-09T11:48:32Z

@juanvallejo @soltysh done.

juanvallejo · 2018-08-09T14:09:33Z

/lgtm

/test pull-kubernetes-e2e-kops-aws

k8s-ci-robot · 2018-08-09T14:09:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/kubectl/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-08-09T15:28:30Z

/test all [submit-queue is verifying that this PR is safe to merge]

ChiuWang · 2018-08-09T16:18:02Z

/test pull-kubernetes-e2e-kops-aws

k8s-github-robot · 2018-08-09T17:03:05Z

Automatic merge from submit-queue (batch tested with PRs 66652, 67034). If you want to cherry-pick this change to another branch, please follow the instructions here.

mkumatag · 2018-08-20T12:19:08Z

I'm not sure how this one got skipped! very important feature in case of sos report.! don't we have any proper testcases to cover this scenario?

mkumatag · 2018-08-20T12:19:40Z

can someone help to cherrypick this to 1.11 release?

…66652-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #66652: fix cluster-info dump error Cherry pick of #66652 on release-1.11. #66652: fix cluster-info dump error **Release note**: ```release-note fix cluster-info dump error ```

k8s-ci-robot requested review from deads2k and ericchiang July 26, 2018 08:21

k8s-ci-robot assigned juanvallejo Jul 26, 2018

ChiuWang mentioned this pull request Jul 26, 2018

Add test for kubectl cluster-info dump #66515

Merged

justinsb added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jul 26, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2018

juanvallejo suggested changes Aug 1, 2018

View reviewed changes

ChiuWang force-pushed the clusterinfo_dump branch 2 times, most recently from 2d79d30 to cf852c7 Compare August 2, 2018 05:12

juanvallejo approved these changes Aug 2, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2018

soltysh requested changes Aug 3, 2018

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2018

ChiuWang force-pushed the clusterinfo_dump branch from cf852c7 to de5bfc8 Compare August 7, 2018 09:05

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2018

ChiuWang force-pushed the clusterinfo_dump branch 3 times, most recently from 54c116f to 8aa0e07 Compare August 7, 2018 10:24

ChiuWang force-pushed the clusterinfo_dump branch from 8aa0e07 to 816ba43 Compare August 7, 2018 10:43

fgeorgatos mentioned this pull request Aug 7, 2018

kubectl cluster-info dump doesn't appear to work after kubeadm install #65221

Closed

ChiuWang force-pushed the clusterinfo_dump branch from 816ba43 to d865266 Compare August 8, 2018 01:27

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2018

soltysh approved these changes Aug 9, 2018

View reviewed changes

Comment thread pkg/kubectl/cmd/clusterinfo_dump.go Outdated

Copy link
Copy Markdown

Contributor

soltysh Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly AppsClient is the preferred name.

k8s-ci-robot assigned soltysh Aug 9, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018

fix cluster-info dump error

6ca446c

ChiuWang force-pushed the clusterinfo_dump branch from d865266 to 6ca446c Compare August 9, 2018 11:44

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2018

k8s-github-robot merged commit 31d1909 into kubernetes:master Aug 9, 2018

juanvallejo mentioned this pull request Aug 20, 2018

Automated cherry pick of #66652: fix cluster-info dump error #67611

Merged

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2018

Conversation

ChiuWang commented Jul 26, 2018 • edited by soltysh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChiuWang commented Jul 26, 2018

Uh oh!

ChiuWang commented Jul 28, 2018

Uh oh!

CaoShuFeng commented Jul 30, 2018

Uh oh!

ChiuWang commented Jul 30, 2018

Uh oh!

ChiuWang commented Jul 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ming19871211 commented Aug 2, 2018

Uh oh!

juanvallejo commented Aug 2, 2018

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanvallejo commented Aug 8, 2018

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChiuWang commented Aug 9, 2018

Uh oh!

juanvallejo commented Aug 9, 2018

Uh oh!

k8s-ci-robot commented Aug 9, 2018

Uh oh!

k8s-github-robot commented Aug 9, 2018

Uh oh!

ChiuWang commented Aug 9, 2018

Uh oh!

k8s-github-robot commented Aug 9, 2018

Uh oh!

mkumatag commented Aug 20, 2018

Uh oh!

mkumatag commented Aug 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ChiuWang commented Jul 26, 2018 •

edited by soltysh

Loading