[13.x] Introduce validateHtml()#60025
Closed
weshooper wants to merge 9 commits into
Closed
Conversation
Pros: - Feels a fairly common thing others may want to do (it's not far off a port from our own codebase, i.e. sharing a problem we've solved) - It mirrors, and is based off, `validateJson()` thanks to new `HTMLDocument` in PHP 8.4 Cons: - Requires PHP 8.4 and Laravel 13 supports PHP 8.3 (perhaps not an issue, i.e. could note in docs, and you know, just don't use it?) - I've never touched validation code before, probably be sensible for someone who can validate(!) security implications (hence Draft status)
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros:
validateJson()thanks to newHTMLDocumentin PHP 8.4Cons:
Requires PHP 8.4 and Laravel 13 supports PHP 8.3 (perhaps not an issue, i.e. could note in docs, and you know, just don't use it? but no idea about failing tests etc.)