Vello CPU: Add public API to render with offset/stride#1597
Open
nicoburns wants to merge 1 commit intolinebender:mainfrom
Open
Vello CPU: Add public API to render with offset/stride#1597nicoburns wants to merge 1 commit intolinebender:mainfrom
nicoburns wants to merge 1 commit intolinebender:mainfrom
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
994c886 to
9a1d24f
Compare
nicoburns
commented
Apr 25, 2026
Comment on lines
234
to
235
| let mut regions = | ||
| Regions::new(bbox_width, bbox_height, pixmap.data_as_u8_slice_mut()); |
Contributor
Author
There was a problem hiding this comment.
I did not update this instance of Regions::new, as I think it's rendering into an intermediate layer and not the output buffer. Does that seems correct?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PixmapMut<'_>and stride invello_cpu? #1382This PR is pretty simple as the logic for doing this already existed (I think added for
RenderContext::composite_to_pixmap_at_offset, and this just plumbing through 4 extrau16parameters in a bunch of places.Todo
The logic in this PR is unfortunately not quite right as things stand. Testing shows the stride not being accounted for even when using the new method)(looks like I'd just missed a method that needed to be updated)