Add further support for EndpointSlice in multicluster & healthcheck#14953
Add further support for EndpointSlice in multicluster & healthcheck#14953matt-mercer wants to merge 1 commit intolinkerd:mainfrom
Conversation
21a8ca0 to
c04e6fe
Compare
c04e6fe to
b867d66
Compare
b867d66 to
9ab05d9
Compare
9ab05d9 to
dcf8d78
Compare
|
@adleong any chance I can get a review on this ? / the pipelines enabled ? |
dcf8d78 to
94e0e77
Compare
d573c4a to
864c866
Compare
|
@adleong ready for another review plx |
|
Hi @matt-mercer thanks for your patience with this. This is a change we definitely want to accept, since it will clean up a large number of deprecation warnings in our logs. However, since Endpoints handling is a very core part of functionality, we want to make sure we spend the proper time reviewing and testing this. We expect to review and test this PR in roughly the June timeframe. |
great, thanks @adleong , definitely needs more eyes on it .. I'm definitely no golang expert. |
While EndpointSlice was used in key locations certain paths do not yet use EndpointSlice as described in linkerd#14781 Added support to service-mirror, including new cluster_watcher_headless service in multicluster. Updated healthcheck checkMisconfiguredOpaquePort checks to support EndpointSlice. New test file cluster_watcher_endpointslice_test, and tests added to healthcheck_test. Signed-off-by: Matt Mercer <reg.linkerd2@vurtechs.com> Signed-off-by: matt-mercer <449892+matt-mercer@users.noreply.github.com>
864c866 to
c386bae
Compare
While EndpointSlice was used in key locations certain paths do not yet use EndpointSlice as described in #14781
Added support to service-mirror, including new cluster_watcher_headless service in multicluster. Updated healthcheck checkMisconfiguredOpaquePort checks to support EndpointSlice.
New test file cluster_watcher_endpointslice_test, and tests added to healthcheck_test.