Skip to content

test: [DI-29822] - Add spec for create notification channel#13383

Merged
venkymano-akamai merged 6 commits into
linode:developfrom
shnagend-akamai:create_notification_channel_alert_linode_February_09
Feb 16, 2026
Merged

test: [DI-29822] - Add spec for create notification channel#13383
venkymano-akamai merged 6 commits into
linode:developfrom
shnagend-akamai:create_notification_channel_alert_linode_February_09

Conversation

@shnagend-akamai
Copy link
Copy Markdown
Contributor

@shnagend-akamai shnagend-akamai commented Feb 9, 2026

Description 📝

This PR adds a new test specification (spec) relating to creating a notification channel in the Linode Manager application. It is basically work done as part of DI-29084, which is a ticket related to the notification channel feature.

Changes 🔄

  • Adds a test spec file to cover the "create notification channel" functionality.
  • This may include UI test scripts (e.g., using Cypress or a similar tool) to automate the workflow of creating a notification channel via the application interface.
  • The new specs likely ensure that notifications channels can be created successfully, and that UI and backend behaviors are as expected.

Target release date 🗓️

24th Feb

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

alert-notification-channel-create.spec.ts.mp4

How to test 🧪

pnpm cy:run -s "cypress/e2e/core/cloudpulse/alert-notification-channel-create.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai santoshp210-akamai added e2e Indicates that a PR touches Cypress tests in some way Cloud Pulse Cloud Pulse - Alerting labels Feb 10, 2026
@shnagend-akamai shnagend-akamai marked this pull request as ready for review February 10, 2026 13:53
@shnagend-akamai shnagend-akamai requested a review from a team as a code owner February 10, 2026 13:53
.click();

// Validate API request payload for notification channel creation
cy.wait('@createAlertChannelNew').then((interception) => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block of code doesn't test anything in the UI, it's just testing the test code which mocks the response. the test below where you filter for the label to ensure that the new item is visible is sufficient and does this better.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed but since we are also carrying out integration testing, the payload validation is covered as part of that flow. A similar implementation has been consistently followed across other test cases as well to ensure the right values are passed to the appropriate labels maintaining end-to-end confidence.
cc : @venkymano-akamai , @santoshp210-akamai

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Feb 12, 2026
@linode-gh-bot
Copy link
Copy Markdown

Cloud Manager UI test results

🎉 868 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing868 Passing11 Skipped43m 11s

@venkymano-akamai venkymano-akamai merged commit b7d15a9 into linode:develop Feb 16, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cloud Pulse - Alerting Cloud Pulse e2e Indicates that a PR touches Cypress tests in some way

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants