upcoming: [UIE-10174] - Update Database types for Hostname changes#13386
Conversation
…ty to DatabaseHosts
…ata for Databases
dwiley-akamai
left a comment
There was a problem hiding this comment.
Approved pending addition of standby-connection-pool as a role
| private_access: true, | ||
| port: 12345, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
This looks good to me, but as a future change, I'd suggest making the 'endpoints' array content dynamic based on the VPC configuration. We could have it render different endpoints based on the settings, similar to how it behaves in the backend.
That way, it'd be easier to test the display behavior for the fields that appear in the UI and we could even add a comment to give insight into the backend behavior.
But since we're still confirming the behavior, we could consider it one of the upcoming tickets for this instead.
smans-akamai
left a comment
There was a problem hiding this comment.
This looks good and my feedback has been addressed! I left an additional comment on some behavior we could include in one of the upcoming pull requests around this feature.
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
Description 📝
Deprecate
connection_pool_portproperty and addendpointsarray to DatabaseHosts to support backend hostname changes along with factory/mock updatesScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Next release
Preview 📷
No visual changes
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅