Skip to content

Fix logging error with ollama client#5917

Merged
peterychang merged 2 commits intomainfrom
ekzhu-fix-ollama-logging
Mar 12, 2025
Merged

Fix logging error with ollama client#5917
peterychang merged 2 commits intomainfrom
ekzhu-fix-ollama-logging

Conversation

@ekzhu
Copy link
Copy Markdown
Contributor

@ekzhu ekzhu commented Mar 12, 2025

Resolves #5910

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (8199a2c) to head (a3e0b1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5917      +/-   ##
==========================================
+ Coverage   70.15%   75.54%   +5.39%     
==========================================
  Files         263      191      -72     
  Lines       15120    13082    -2038     
  Branches      256        0     -256     
==========================================
- Hits        10607     9883     -724     
+ Misses       4313     3199    -1114     
+ Partials      200        0     -200     
Flag Coverage Δ
unittests 75.54% <ø> (+5.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterychang peterychang merged commit 4d8b97e into main Mar 12, 2025
@peterychang peterychang deleted the ekzhu-fix-ollama-logging branch March 12, 2025 20:59
ekzhu added a commit that referenced this pull request Mar 14, 2025
Resolves #5910

Co-authored-by: peterychang <49209570+peterychang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama throw "Object of type Message is not JSON serializable" error

2 participants