Skip to content

Fix poe check on Windows#5942

Merged
ekzhu merged 2 commits intomicrosoft:mainfrom
nissa-seru:main
Mar 14, 2025
Merged

Fix poe check on Windows#5942
ekzhu merged 2 commits intomicrosoft:mainfrom
nissa-seru:main

Conversation

@nissa-seru
Copy link
Copy Markdown
Contributor

@nissa-seru nissa-seru commented Mar 14, 2025

Why are these changes needed?

poe check fails on main on Windows due to a combination line ending mismatches, Unix-specific commands, and Windows-specific asyncio behavior. This PR attempts to fix this (so that poe check on a freshly-pulled main passes on Windows 11.)

Checks

@nissa-seru
Copy link
Copy Markdown
Contributor Author

As a side note, I recommend bumping llama-cpp-python in packages\autogen-ext\pyproject.toml to >=0.3.8. The current value of >=0.1.9 causes uv to default to fetching 0.3.7, at least when I uv sync --all-extras on Python 3.12.8 - which leads to the uv sync failing due to ggml-org/llama.cpp#11836 (the fix for which was pulled into llama-cpp-python as of version 0.3.8 when it updated llama.cpp.) I did not include this bump in the PR, but noting here since probably not worth a separate PR just for the bump.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.76%. Comparing base (b8b7a2d) to head (73e70c4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/src/autogen_ext/code_executors/local/__init__.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5942      +/-   ##
==========================================
- Coverage   75.77%   75.76%   -0.01%     
==========================================
  Files         191      191              
  Lines       13107    13114       +7     
==========================================
+ Hits         9932     9936       +4     
- Misses       3175     3178       +3     
Flag Coverage Δ
unittests 75.76% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu merged commit 0276aac into microsoft:main Mar 14, 2025
ekzhu added a commit that referenced this pull request Mar 14, 2025
use the latest version of llama-cpp-python to ensure `uv sync
--all-extras` don't fail on windows.

reference:
#5942 (comment)
ekzhu added a commit that referenced this pull request Mar 14, 2025
use the latest version of llama-cpp-python to ensure `uv sync
--all-extras` don't fail on windows.

reference:
#5942 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants