Ensure SecretStr is cast to str on load for model clients#5947
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5947 +/- ##
==========================================
- Coverage 75.77% 75.76% -0.01%
==========================================
Files 191 191
Lines 13100 13107 +7
==========================================
+ Hits 9927 9931 +4
- Misses 3173 3176 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ekzhu
approved these changes
Mar 14, 2025
ekzhu
pushed a commit
that referenced
this pull request
Mar 14, 2025
Currently we have SecretStr type for model clients to promote security best practices. - when we dump_component, keys are serialized as SecreteStr .. - when we load_component ... SecreteStr type is passed to the client in the api_key field. This i causes the type problems as the clients expect a string type. This PR updates the from_config method for model clients to ensure we get the value from SecretStr. Closes #5944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently we have SecretStr type for model clients to promote security best practices.
This PR updates the from_config method for model clients to ensure we get the value from SecretStr.
Related issue number
Closes #5944
Checks