Skip to content

add stdio_read_timeout for create_mcp_server_session#6080

Merged
ekzhu merged 8 commits intomicrosoft:mainfrom
Septa2112:SessionTimeout
Mar 26, 2025
Merged

add stdio_read_timeout for create_mcp_server_session#6080
ekzhu merged 8 commits intomicrosoft:mainfrom
Septa2112:SessionTimeout

Conversation

@Septa2112
Copy link
Copy Markdown
Contributor

@Septa2112 Septa2112 commented Mar 24, 2025

Why are these changes needed?

If no timeout here, the program will hang when it fails to create the MCP server.

Related issue number

Closes #6031

Checks

@Septa2112
Copy link
Copy Markdown
Contributor Author

@Septa2112 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.请阅读以下贡献者许可协议 (CLA)。如果您同意 CLA,请回复以下信息。

@microsoft-github-policy-service agree [company="{your company}"]

Options:  选项:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.(默认 - 未指定公司)我对我的提交内容拥有唯一的知识产权,并且在为我的雇主工作期间,我不会提交提交内容。
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.(当公司指定时)我在工作过程中为我的雇主提交内容(或者我的雇主根据合同或适用法律对我的提交内容拥有知识产权)。我已获得雇主的许可,可以代表我的雇主提交内容并签订本协议。通过在下面签名,定义的术语“您”包括我和我的雇主。
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
贡献者许可协议

@microsoft-github-policy-service agree company="Intel"

Comment thread python/packages/autogen-ext/src/autogen_ext/tools/mcp/_config.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (0bec835) to head (2363745).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../autogen-ext/src/autogen_ext/tools/mcp/_session.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6080   +/-   ##
=======================================
  Coverage   76.77%   76.77%           
=======================================
  Files         191      191           
  Lines       13240    13241    +1     
=======================================
+ Hits        10165    10166    +1     
  Misses       3075     3075           
Flag Coverage Δ
unittests 76.77% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu enabled auto-merge (squash) March 26, 2025 17:46
@ekzhu ekzhu merged commit ce92926 into microsoft:main Mar 26, 2025
55 checks passed
@Septa2112 Septa2112 deleted the SessionTimeout branch March 27, 2025 02:16
ekzhu added a commit that referenced this pull request Mar 29, 2025
Closes #6031 

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP tool should have a timeout setting.

2 participants