fix: validate participants type in BaseGroupChat.__init__#7607
Open
nileshpatil6 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: validate participants type in BaseGroupChat.__init__#7607nileshpatil6 wants to merge 2 commits intomicrosoft:mainfrom
nileshpatil6 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Passing a non-list value (None, int, str) as participants causes a cryptic AttributeError or TypeError deep in the stack. Adding an explicit isinstance check before len() surfaces a clear TypeError immediately at construction time. Fixes microsoft#7580
Author
|
@microsoft-github-policy-service agree |
Passing a non-list value (None, int, str) as participants causes a cryptic AttributeError or TypeError deep in the stack. Adding an explicit isinstance check before len() surfaces a clear TypeError immediately at construction time. Fixes microsoft#7580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Passing a non-list value (
None,int,str) asparticipantstoRoundRobinGroupChat(or anyBaseGroupChatsubclass) causes a crypticAttributeErrororTypeErrordeep in the call stack — e.g.,'NoneType' object has no attribute '__len__'or errors insideset(participant.name for participant in participants).Fix
Add an explicit
isinstance(participants, list)check before thelen()call so the error is caught immediately at construction time with a clear message:Fixes #7580