Improve control on custom icon display on login page#3125
Closed
weilai-irl wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an admin-configurable toggle to control whether the OpenID Connect provider icon is displayed on Moodle’s login page, and conditionally hides related icon settings when disabled.
Changes:
- Add a new admin setting (
auth_oidc/set_pix) to control icon display on the login page. - Hide the icon picker and custom icon upload settings when icon display is disabled.
- Adjust
loginpage_idp_list()to conditionally include icon data in the returned IdP list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| auth/oidc/settings.php | Adds the new “show icon” checkbox and uses it to conditionally hide icon-related settings. |
| auth/oidc/lang/en/auth_oidc.php | Adds the English string for the new setting label. |
| auth/oidc/classes/loginflow/authcode.php | Uses the new config flag to decide whether to return icon data for the login page IdP list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2dd920e to
8d5cd42
Compare
Collaborator
Author
|
This PR has been included in the 2026 May release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.