Update auth code validation according to RFC 6749#3163
Open
weilai-irl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the validation logic for OIDC redirect parameters (notably the authorization code and state) in the auth_oidc auth-code login flow, aiming to accept a wider set of RFC-compliant values.
Changes:
- Updated the
getoidcparam()docblock to describe RFC 6749 VSCHAR-based validation. - Replaced the previous Base64-variant character whitelist with a visible-ASCII range-based filter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
de0c614 to
9b1c182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.