Skip to content

fix: improve system robustness by safely handling regex syntax errors#8276

Open
RinZ27 wants to merge 1 commit into
nasa:masterfrom
RinZ27:fix/regex-robustness-patch
Open

fix: improve system robustness by safely handling regex syntax errors#8276
RinZ27 wants to merge 1 commit into
nasa:masterfrom
RinZ27:fix/regex-robustness-patch

Conversation

@RinZ27

@RinZ27 RinZ27 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Closes (Active patch for system robustness)

Describe your changes:

This update focuses on strengthening the robustness of Open MCT by safely handling user-provided Regular Expressions. Previously, invalid Regex strings (e.g., missing closing parentheses or unescaped special characters) in telemetry table filters, timelist searches, or form fields could trigger uncaught SyntaxError exceptions. These errors resulted in UI component crashes or the termination of background workers (such as WebSocketWorker), interrupting critical telemetry data flows.

Changes include wrapping new RegExp() calls in try-catch blocks across key files: TableRowCollection.js, TimelistComponent.vue, WebSocketWorker.js, FormRow.vue, and TextHighlight.vue. Instead of allowing exceptions to propagate and degrade the user experience, the system now handles errors gracefully by ignoring invalid filters or marking form inputs as invalid. These additions protect the system from unintentional input errors by operators in high-pressure real-world scenarios, ensuring the continuity of telemetry monitoring.

All Submissions:

Author Checklist

  • Changes address original issue? (System Robustness)
  • Tests included and/or updated with changes? (Logic verified via manual testing with invalid patterns)
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? type:bug

@RinZ27 RinZ27 marked this pull request as ready for review March 10, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant