fix: improve system robustness by safely handling regex syntax errors#8276
Open
RinZ27 wants to merge 1 commit into
Open
fix: improve system robustness by safely handling regex syntax errors#8276RinZ27 wants to merge 1 commit into
RinZ27 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes (Active patch for system robustness)
Describe your changes:
This update focuses on strengthening the robustness of Open MCT by safely handling user-provided Regular Expressions. Previously, invalid Regex strings (e.g., missing closing parentheses or unescaped special characters) in telemetry table filters, timelist searches, or form fields could trigger uncaught
SyntaxErrorexceptions. These errors resulted in UI component crashes or the termination of background workers (such asWebSocketWorker), interrupting critical telemetry data flows.Changes include wrapping
new RegExp()calls intry-catchblocks across key files:TableRowCollection.js,TimelistComponent.vue,WebSocketWorker.js,FormRow.vue, andTextHighlight.vue. Instead of allowing exceptions to propagate and degrade the user experience, the system now handles errors gracefully by ignoring invalid filters or marking form inputs as invalid. These additions protect the system from unintentional input errors by operators in high-pressure real-world scenarios, ensuring the continuity of telemetry monitoring.All Submissions:
Author Checklist
type:label?type:bug