-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
Use simdjson::pad to pad strings to be parsed by simdjson #59389
Copy link
Copy link
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
See joyeecheung#8 for a reference.
This might also be applicable to
node/src/node_modules.cc
Lines 116 to 120 in 50cfc6c
There is another place where we are manually padding the buffer, but I am not so sure whether using simdjson::pad is better than the current handling. I'd suggest first time contributors to avoid it unless you can assess the impact between the current approach and using
simdjson::padand find the latter to be preferrable.node/src/inspector_profiler.cc
Lines 128 to 131 in 7215d9b