Skip to content

test: avoid test_runner watch restart in spec snapshot#63392

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-output-test-runner-watch-spec
Open

test: avoid test_runner watch restart in spec snapshot#63392
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-output-test-runner-watch-spec

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 17, 2026

This updates the test_runner watch-mode spec reporter fixture to pass
explicit test files to run().

The fixture no longer watches the whole temporary directory, so setup writes
cannot race with watcher initialization and emit an unexpected restart banner.

Refs:


Assisted-by: openai:gpt-5.5

Pass explicit test files to the watch-mode spec reporter fixture.
This prevents setup writes from triggering a watch restart.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants