Fix collision errors when introducing history plugin after the fact#991
Open
tarzan wants to merge 4 commits intonorman:masterfrom
Open
Fix collision errors when introducing history plugin after the fact#991tarzan wants to merge 4 commits intonorman:masterfrom
tarzan wants to merge 4 commits intonorman:masterfrom
Conversation
…enerator -> it should be irrelevant
…ble without the extra merged where
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
|
Thank you for redoing this @tarzan 😄 |
Author
Before this becoming stale again: anything keeping you from merging this? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've redone the work of #850
The problem that still exists in this current version is:
The method 'scope_for_slug_generator' did a bit too much work with an inner join that made existing records with no entry in the history table being filtered out.