Skip to content

fix(core): handle package manager workspaces configuration in move generator#30268

Merged
leosvelperez merged 4 commits intomasterfrom
workspace/move-handle-package-manager-workspaces
Mar 11, 2025
Merged

fix(core): handle package manager workspaces configuration in move generator#30268
leosvelperez merged 4 commits intomasterfrom
workspace/move-handle-package-manager-workspaces

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Current Behavior

Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration results in the project not included in the package manager workspaces setup.

Expected Behavior

Moving a project included in the package manager workspaces setup to a new destination that's not matched by that configuration should result in the new destination included in the workspaces setup.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 5, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner March 5, 2025 11:06
@leosvelperez leosvelperez requested a review from MaxKless March 5, 2025 11:06
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 10:30am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 5, 2025

View your CI Pipeline Execution ↗ for commit af4d617.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m 46s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=2d872... ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 10s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 31m 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-06 11:12:01 UTC

Comment thread packages/workspace/package.json
Comment thread packages/workspace/src/utilities/typescript/ts-solution-setup.ts Outdated
Copy link
Copy Markdown
Contributor

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@leosvelperez leosvelperez force-pushed the workspace/move-handle-package-manager-workspaces branch from 3c46e21 to 84276ff Compare March 5, 2025 14:47
@leosvelperez leosvelperez requested review from a team and Coly010 as code owners March 5, 2025 14:47
@leosvelperez leosvelperez force-pushed the workspace/move-handle-package-manager-workspaces branch from 84276ff to af4d617 Compare March 6, 2025 10:28
@leosvelperez leosvelperez merged commit 432a645 into master Mar 11, 2025
@leosvelperez leosvelperez deleted the workspace/move-handle-package-manager-workspaces branch March 11, 2025 13:05
FrozenPandaz pushed a commit that referenced this pull request Mar 14, 2025
…nerator (#30268)

## Current Behavior

Moving a project included in the package manager workspaces setup to a
new destination that's not matched by that configuration results in the
project not included in the package manager workspaces setup.

## Expected Behavior

Moving a project included in the package manager workspaces setup to a
new destination that's not matched by that configuration should result
in the new destination included in the workspaces setup.

## Related Issue(s)

Fixes #

(cherry picked from commit 432a645)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants