Skip to content

feat(vite): add ajv dev dependency for vite-plugin-dts#31107

Merged
jaysoo merged 1 commit intomasterfrom
fix/vite-library-error
May 15, 2025
Merged

feat(vite): add ajv dev dependency for vite-plugin-dts#31107
jaysoo merged 1 commit intomasterfrom
fix/vite-library-error

Conversation

@ndcunningham
Copy link
Copy Markdown
Contributor

Current Behavior

Currently, when we generate a vite library that uses vite-plugin-dts it breaks the project graph and all nx commands fail.
It happens because the wrong version of ajv is being hoisted in node_modules/ajv so the expected module path required from vite-plugin-dts is not found.

Expected Behavior

Nx commands should work out of the box when we generate a library with vite.

Related Issue(s)

Fixes #

@ndcunningham ndcunningham self-assigned this May 7, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner May 7, 2025 15:40
@ndcunningham ndcunningham requested a review from mandarini May 7, 2025 15:40
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 9, 2025 3:23pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 7, 2025

View your CI Pipeline Execution ↗ for commit ecb2392.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 33m 29s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 16:00:06 UTC

Comment thread packages/vite/src/utils/versions.ts Outdated
@ndcunningham ndcunningham force-pushed the fix/vite-library-error branch from c39ce15 to e7db9d4 Compare May 9, 2025 15:14
@ndcunningham ndcunningham enabled auto-merge (squash) May 9, 2025 15:16
@ndcunningham ndcunningham force-pushed the fix/vite-library-error branch from e7db9d4 to ecb2392 Compare May 9, 2025 15:21
@ndcunningham ndcunningham requested a review from a team as a code owner May 9, 2025 15:21
@ndcunningham ndcunningham requested a review from FrozenPandaz May 9, 2025 15:21
@jaysoo jaysoo disabled auto-merge May 15, 2025 19:44
@jaysoo jaysoo merged commit d3ecffe into master May 15, 2025
6 checks passed
@jaysoo jaysoo deleted the fix/vite-library-error branch May 15, 2025 19:44
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants