Skip to content

feat: enable EnableRemoteLinkPicker WOPI flag for Collabora Online#2663

Open
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva:feat/enable-remote-link-picker
Open

feat: enable EnableRemoteLinkPicker WOPI flag for Collabora Online#2663
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva:feat/enable-remote-link-picker

Conversation

@pedropintosilva
Copy link
Copy Markdown
Contributor

Set EnableRemoteLinkPicker: true in CheckFileInfo response so
Collabora Online exposes its "Smart Picker" UI for link
insertion. Clicking it sends a UI_PickLink postMessage to the WOPI
host, which is expected to reply with Action_InsertLink carrying the
URL of the selected file. Follows the same pattern as the existing
EnableInsertRemoteImage / EnableInsertRemoteFile flags.

Signed-off-by: Pedro Pinto Silva pedro.silva@collabora.com


go test ./services/collaboration/pkg/connector/... passes


When the flag is enabled, clicking the Smart Picker button in Collabora fires a UI_PickLink postMessage to the WOPI host. The host opens its file picker and replies with Action_InsertLink carrying the selected document's URL (and an optional text label).

The text label is honored upstream since CollaboraOnline/online#15561 (MERGED) — older coolwsd simply falls back to the URL. SDK reference: https://sdk.collaboraonline.com/docs/advanced_integration.html#enableremotelinkpicker

Set EnableRemoteLinkPicker: true in CheckFileInfo response so
Collabora Online exposes its "Smart Picker" UI for link
insertion. Clicking it sends a UI_PickLink postMessage to the WOPI
host, which is expected to reply with Action_InsertLink carrying the
URL of the selected file. Follows the same pattern as the existing
EnableInsertRemoteImage / EnableInsertRemoteFile flags.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@pedropintosilva
Copy link
Copy Markdown
Contributor Author

cc: @micbar

Copy link
Copy Markdown
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny remark, rest LGTM and works just fine.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add changelog items, this will be handled automatically via the PR title (I guess we should just kill the folder at some point).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants