Customize color palette with .glsrc file#25
Merged
ozansz merged 2 commits intoozansz:mainfrom Oct 11, 2022
Merged
Conversation
* `readGLSRCFile` function added. This function reads and overrides the vars. * Testdata added. * Tests added. * README updated. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
ozansz
reviewed
Oct 11, 2022
Owner
ozansz
left a comment
There was a problem hiding this comment.
thank you for the contribution! also the PR is well-documented
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readGLSRCFilefunction added. This function reads and overrides the vars.Signed-off-by: Gökhan Özeloğlu gokhan.ozeloglu@deliveryhero.com
Summary
Fixes #16
I added a new feature for customizing the color palette by
.glsrcfile.Impact
Testing
Tests are using
testdataunder theguidirectory. There is no special instruction to run the tests.Test Configuration:
go1.18.2 darwin/amd64MBP 2019 16 GB RAM 2,3 GHz 8-Core Intel Core i9 DDR4macOS Monterey