Ensure that facet suggestions are relevant to the user's query#3495
Merged
Conversation
Before this commit, the facet suggest javascript sent HTTP requests that included only the name of the facet and the fragment that the user entered to filter down the facets. This commit also sends any URL params that were in the user's original search, so that the facet suggestions are relevant to the search, rather than being just the most popular facet values from the entire corpus. Closes #3494
607cb00 to
f3a53b5
Compare
jcoyne
approved these changes
Jan 27, 2025
sandbergja
added a commit
that referenced
this pull request
Jan 30, 2025
…vant to the user's query (#3501) * Ensure that facet suggestions are relevant to the user's query Before this commit, the facet suggest javascript sent HTTP requests that included only the name of the facet and the fragment that the user entered to filter down the facets. This commit also sends any URL params that were in the user's original search, so that the facet suggestions are relevant to the search, rather than being just the most popular facet values from the entire corpus. Closes #3494 * Put test into configured context --------- Co-authored-by: Max Kadel <mkadel@princeton.edu>
sandbergja
added a commit
to pulibrary/orangelight
that referenced
this pull request
Feb 4, 2025
Helps with #4025, since it includes the fix to projectblacklight/blacklight#3495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the facet suggest javascript sent HTTP requests that included only the name of the facet and the fragment that the user entered to filter down the facets.
This commit also sends any URL params that were in the user's original search, so that the facet suggestions are relevant to the search, rather than being just the most popular facet values from the entire corpus.
Closes #3494