Permit markup on prev/next session context buttons#3583
Merged
Conversation
Previously, if a button was customized to have child DOM elements, such as: ```html <a href="..." data-context-href="..."><span>Text</span></a> ``` it would not receive the intended behavior. Becuase the click target would be a child element (the span in this case), not the element with the required dataset attributes
dnoneill
approved these changes
Apr 25, 2025
jcoyne
added a commit
that referenced
this pull request
Apr 29, 2025
Previously, if a button was customized to have child DOM elements, such as: ```html <a href="..."><span>Text</span></a> ``` it would not receive the intended behavior. Becuase the click target would be a child element (the span in this case), not the link element. This is similar to #3583
jcoyne
added a commit
that referenced
this pull request
Apr 29, 2025
Previously, if a button was customized to have child DOM elements, such as: ```html <a href="..."><span>Text</span></a> ``` it would not receive the intended behavior. Becuase the click target would be a child element (the span in this case), not the link element. This is similar to #3583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a button was customized to have child DOM elements, such as:
it would not receive the intended behavior. Becuase the click target would be a child element (the span in this case), not the element with the required dataset attributes