Update to view_component 4.0#3706
Conversation
917f553 to
d679c46
Compare
sandbergja
left a comment
There was a problem hiding this comment.
Thanks so much for getting Blacklight working with the new ViewComponent release, @jcoyne ! I had a few questions/thoughts.
5687371 to
adb7238
Compare
| "rails_version": ["7.1.5.1", "7.2.2.1"], | ||
| "bootstrap_version": [null], | ||
| "view_component_version": ["~> 3.12"], | ||
| "view_component_version": ["~> 4.0"], |
There was a problem hiding this comment.
Would it be feasible to test against both 3.x and 4.x?
There was a problem hiding this comment.
I believe it is possible, however it's more complex to support both. Is there a reason we can't just bump the version?
There was a problem hiding this comment.
I thought it would be nice for ease of upgrading (i.e. a blacklight application can upgrade blacklight 8 -> 9, and then upgrade view_component 3 -> 4 separately, rather than having them be coupled and do both upgrades at once).
There was a problem hiding this comment.
It looks like some of the tests would have to be conditional on what version of view_component is running. 😢
There was a problem hiding this comment.
@sandbergja what do you think of this approach?
There was a problem hiding this comment.
While the tests now allow both (love it, for exact reason @sandbergja says), it doesn't look like the matrix was changed to test both?
There was a problem hiding this comment.
I think it was @jrochkind : on the most recent commit on main, I see this job, which says "Installing view_component 3.23.2" in the logs for the Install dependencies step, and this job, which says "Installing view_component 4.0.0"
There was a problem hiding this comment.
Aha, one with ruby 3.3 and one with 3.4. I was misdirected by this one line changing from ViewComponent 3 to 4 instead of expanding to test both, but now I see, thank you for checking!
No description provided.