Add ".js" extension to imports in fluent-react#577
Merged
Conversation
eemeli
approved these changes
Sep 23, 2021
Member
eemeli
left a comment
There was a problem hiding this comment.
Yeah, this looks like a pretty clear case of oversight about applying that change to this file.
Contributor
Author
|
@eemeli looks like github-actions need explicit approval for external contributions. Also, can you cut the release with these changes please? |
Similar change was applied to different modules, but react was skipped somehow. Lack of this change breaks build on webpack5
|
@eemeli what's the status on this? |
Member
|
The status is that this fell somewhere between the todo-lists of @gregtatum and myself, along with a healthy dose of travelling in the interim. In other words, apologies for not getting to this sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar change was applied to different modules, but react was skipped somehow. Lack of this change breaks build on webpack5