Fix HTTPDigestAuth non-latin credentials encoding#7414
Closed
Fix HTTPDigestAuth non-latin credentials encoding#7414
Conversation
When HTTPDigestAuth credentials are passed as bytes (e.g. encoded UTF-8), they were being used directly in the digest header without decoding, resulting in headers like Digest username="b'Ond\xc5\x99ej'" instead of the properly decoded username. This fix decodes bytes username/password to strings before using them in the digest A1 computation and the username header field. Fixes psf#6102
Member
|
Hi @mitre88, I don't believe this is the right fix. It's broken for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HTTPDigestAuth credentials are passed as bytes (e.g. encoded UTF-8), they were being used directly in the digest header without decoding, resulting in headers like
Digest username="b'Ond\xc5\x99ej'".This fix decodes bytes username/password to strings before using them in the digest A1 computation and the username header field.
Fixes #6102